--- name: typescript description: TypeScript code style, type co-location, constant naming conventions, and arktype patterns. Use when writing TypeScript code, defining types, creating constants, or working with arktype schemas. --- # TypeScript Guidelines ## Core Rules - Always use `type` instead of `interface` in TypeScript. - TypeScript 5.5+ automatically infers type predicates in `.filter()` callbacks. Don't add manual type assertions: ```typescript // Good - TypeScript infers the narrowed type automatically const filtered = items.filter((x) => x !== undefined); // Bad - unnecessary type predicate const filtered = items.filter((x): x is NonNullable => x !== undefined); ``` - When moving components to new locations, always update relative imports to absolute imports (e.g., change `import Component from '../Component.svelte'` to `import Component from '$lib/components/Component.svelte'`) - When functions are only used in the return statement of a factory/creator function, use object method shorthand syntax instead of defining them separately. For example, instead of: ```typescript function myFunction() { const helper = () => { /* ... */ }; return { helper }; } ``` Use: ```typescript function myFunction() { return { helper() { /* ... */ }, }; } ``` # Type Co-location Principles ## Never Use Generic Type Buckets Don't create generic type files like `$lib/types/models.ts`. This creates unclear dependencies and makes code harder to maintain. ### Bad Pattern ```typescript // $lib/types/models.ts - Generic bucket for unrelated types export type LocalModelConfig = { ... }; export type UserModel = { ... }; export type SessionModel = { ... }; ``` ### Good Pattern ```typescript // $lib/services/transcription/local/types.ts - Co-located with service export type LocalModelConfig = { ... }; // $lib/services/user/types.ts - Co-located with user service export type UserModel = { ... }; ``` ## Co-location Rules 1. **Service-specific types**: Place in `[service-folder]/types.ts` 2. **Component-specific types**: Define directly in the component file 3. **Shared domain types**: Place in the domain folder's `types.ts` 4. **Cross-domain types**: Only if truly shared across multiple domains, place in `$lib/types/[specific-name].ts` ## Benefits - Clear ownership and dependencies - Easier refactoring and deletion - Better code organization - Reduces coupling between unrelated features # Constant Array Naming Conventions ## Pattern Summary | Pattern | Suffix | Description | Example | |---------|--------|-------------|---------| | Simple values (source of truth) | Plural noun with unit | Raw values array | `BITRATES_KBPS`, `SAMPLE_RATES` | | Rich array (source of truth) | Plural noun | Contains all metadata | `PROVIDERS`, `RECORDING_MODE_OPTIONS` | | IDs only (for validation) | `_IDS` | Derived from rich array | `PROVIDER_IDS` | | UI options `{value, label}` | `_OPTIONS` | For dropdowns/selects | `BITRATE_OPTIONS`, `SAMPLE_RATE_OPTIONS` | | Label map | `_TO_LABEL` (singular) | `Record` | `LANGUAGES_TO_LABEL` | ## When to Use Each Pattern ### Pattern 1: Simple Values -> Derived Options Use when the label can be computed from the value: ```typescript // constants/audio/bitrate.ts export const BITRATES_KBPS = ['16', '32', '64', '128'] as const; export const BITRATE_OPTIONS = BITRATES_KBPS.map((bitrate) => ({ value: bitrate, label: `${bitrate} kbps`, })); ``` ### Pattern 2: Simple Values + Metadata Object Use when labels need richer information than the value alone: ```typescript // constants/audio/sample-rate.ts export const SAMPLE_RATES = ['16000', '44100', '48000'] as const; const SAMPLE_RATE_METADATA: Record = { '16000': { shortLabel: '16 kHz', description: 'Optimized for speech' }, '44100': { shortLabel: '44.1 kHz', description: 'CD quality' }, '48000': { shortLabel: '48 kHz', description: 'Studio quality' }, }; export const SAMPLE_RATE_OPTIONS = SAMPLE_RATES.map((rate) => ({ value: rate, label: `${SAMPLE_RATE_METADATA[rate].shortLabel} - ${SAMPLE_RATE_METADATA[rate].description}`, })); ``` ### Pattern 3: Rich Array as Source of Truth Use when options have extra fields beyond `value`/`label` (e.g., `icon`, `desktopOnly`): ```typescript // constants/audio/recording-modes.ts export const RECORDING_MODES = ['manual', 'vad', 'upload'] as const; export type RecordingMode = (typeof RECORDING_MODES)[number]; export const RECORDING_MODE_OPTIONS = [ { label: 'Manual', value: 'manual', icon: 'mic', desktopOnly: false }, { label: 'Voice Activated', value: 'vad', icon: 'mic-voice', desktopOnly: false }, { label: 'Upload File', value: 'upload', icon: 'upload', desktopOnly: false }, ] as const satisfies { label: string; value: RecordingMode; icon: string; desktopOnly: boolean }[]; // Derive IDs for validation if needed export const RECORDING_MODE_IDS = RECORDING_MODE_OPTIONS.map(o => o.value); ``` ## Choosing a Pattern | Scenario | Pattern | |----------|---------| | Label = formatted value (e.g., "128 kbps") | Simple Values -> Derived | | Label needs separate data (e.g., "16 kHz - Optimized for speech") | Values + Metadata | | Options have extra UI fields (icon, description, disabled) | Rich Array | | Platform-specific or runtime-conditional content | Keep inline in component | ## Naming Rules ### Source Arrays - Use **plural noun**: `PROVIDERS`, `MODES`, `LANGUAGES` - Add unit suffix when relevant: `BITRATES_KBPS`, `SAMPLE_RATES` - Avoid redundant `_VALUES` suffix ### Derived/Options Arrays - Use **plural noun** + `_OPTIONS` suffix: `BITRATE_OPTIONS`, `SAMPLE_RATE_OPTIONS` - For IDs: **plural noun** + `_IDS` suffix: `PROVIDER_IDS` ### Label Maps - Use **singular** `_TO_LABEL` suffix: `LANGUAGES_TO_LABEL` - Describes the operation (id -> label), not the container - Reads naturally: `LANGUAGES_TO_LABEL[lang]` = "get the label for this language" ### Constant Casing - Always use `SCREAMING_SNAKE_CASE` for exported constants - Never use `camelCase` for constant objects/arrays ## Co-location Options arrays should be co-located with their source array in the same file. Avoid creating options inline in Svelte components; import pre-defined options instead. Exception: Keep options inline when they have platform-specific or runtime-conditional content that would require importing platform constants into the data module. # Parameter Destructuring for Factory Functions ## Prefer Parameter Destructuring Over Body Destructuring When writing factory functions that take options objects, destructure directly in the function signature instead of in the function body. This is the established pattern in the codebase. ### Bad Pattern (Body Destructuring) ```typescript // DON'T: Extra line of ceremony function createSomething(opts: { foo: string; bar?: number }) { const { foo, bar = 10 } = opts; // Unnecessary extra line return { foo, bar }; } ``` ### Good Pattern (Parameter Destructuring) ```typescript // DO: Destructure directly in parameters function createSomething({ foo, bar = 10 }: { foo: string; bar?: number }) { return { foo, bar }; } ``` ### Why This Matters 1. **Fewer lines**: Removes the extra destructuring statement 2. **Defaults at API boundary**: Users see defaults in the signature, not hidden in the body 3. **Works with `const` generics**: TypeScript literal inference works correctly: ```typescript function select({ options, nullable = false, }: { options: TOptions; nullable?: boolean; }) { ... } ``` 4. **Closures work identically**: Inner functions capture the same variables either way ### When Body Destructuring is Valid - Need to distinguish "property missing" vs "property is `undefined`" (`'key' in opts`) - Complex normalization/validation of the options object - Need to pass the entire `opts` object to other functions ### Codebase Examples ```typescript // From packages/epicenter/src/core/schema/columns.ts export function select({ options, nullable = false, default: defaultValue, }: { options: TOptions; nullable?: boolean; default?: TOptions[number]; }): SelectColumnSchema { return { type: 'select', nullable, options, default: defaultValue }; } // From apps/whispering/.../create-key-recorder.svelte.ts export function createKeyRecorder({ pressedKeys, onRegister, onClear, }: { pressedKeys: PressedKeys; onRegister: (keyCombination: KeyboardEventSupportedKey[]) => void; onClear: () => void; }) { ... } ``` # Arktype Optional Properties ## Never Use `| undefined` for Optional Properties When defining optional properties in arktype schemas, always use the `'key?'` syntax instead of `| undefined` unions. This is critical for JSON Schema conversion (used by OpenAPI/MCP). ### Bad Pattern ```typescript // DON'T: Explicit undefined union - breaks JSON Schema conversion const schema = type({ window_id: 'string | undefined', url: 'string | undefined', }); ``` This produces invalid JSON Schema with `anyOf: [{type: "string"}, {}]` because `undefined` has no JSON Schema equivalent. ### Good Pattern ```typescript // DO: Optional property syntax - converts cleanly to JSON Schema const schema = type({ 'window_id?': 'string', 'url?': 'string', }); ``` This correctly omits properties from the `required` array in JSON Schema. ### Why This Matters | Syntax | TypeScript Behavior | JSON Schema | |--------|---------------------|-------------| | `key: 'string \| undefined'` | Required prop, accepts string or undefined | Broken (triggers fallback) | | `'key?': 'string'` | Optional prop, accepts string | Clean (omitted from `required`) | Both behave similarly in TypeScript, but only the `?` syntax converts correctly to JSON Schema for OpenAPI documentation and MCP tool schemas.