--- name: git-workflow-and-versioning description: Use when making any code change. Use when committing, branching, resolving conflicts, or when you need to organize work across multiple parallel streams. --- # Git Workflow and Versioning ## Overview Git is your safety net. Treat commits as save points, branches as sandboxes, and history as documentation. With AI agents generating code at high speed, disciplined version control is the mechanism that keeps changes manageable, reviewable, and reversible. ## When to Use Always. Every code change flows through git. ## Core Principles ### 1. Commit Early, Commit Often Each successful increment gets its own commit. Don't accumulate large uncommitted changes. ``` Work pattern: Implement slice → Test → Verify → Commit → Next slice Not this: Implement everything → Hope it works → Giant commit ``` Commits are save points. If the next change breaks something, you can revert to the last known-good state instantly. ### 2. Atomic Commits Each commit does one logical thing: ``` # Good: Each commit is self-contained git log --oneline a1b2c3d Add task creation endpoint with validation d4e5f6g Add task creation form component h7i8j9k Connect form to API and add loading state m1n2o3p Add task creation tests (unit + integration) # Bad: Everything mixed together git log --oneline x1y2z3a Add task feature, fix sidebar, update deps, refactor utils ``` ### 3. Descriptive Messages Commit messages explain the *why*, not just the *what*: ``` # Good: Explains intent feat: add email validation to registration endpoint Prevents invalid email formats from reaching the database. Uses Zod schema validation at the route handler level, consistent with existing validation patterns in auth.ts. # Bad: Describes what's obvious from the diff update auth.ts ``` **Format:** ``` : ``` **Types:** - `feat` — New feature - `fix` — Bug fix - `refactor` — Code change that neither fixes a bug nor adds a feature - `test` — Adding or updating tests - `docs` — Documentation only - `chore` — Tooling, dependencies, config ### 4. Never Mix Concerns Don't combine formatting changes with behavior changes. Don't combine refactors with features. Each type of change should be a separate commit: ``` # Good: Separate concerns git commit -m "refactor: extract validation logic to shared utility" git commit -m "feat: add phone number validation to registration" # Bad: Mixed concerns git commit -m "refactor validation and add phone number field" ``` ## Branching Strategy ### Feature Branches ``` main (always deployable) │ ├── feature/task-creation ← One feature per branch ├── feature/user-settings ← Parallel work └── fix/duplicate-tasks ← Bug fixes ``` - Branch from `main` (or the team's default branch) - Keep branches short-lived (merge within 1-3 days) - Delete branches after merge ### Branch Naming ``` feature/ → feature/task-creation fix/ → fix/duplicate-tasks chore/ → chore/update-deps refactor/ → refactor/auth-module ``` ## Working with Worktrees For parallel AI agent work, use git worktrees to run multiple branches simultaneously: ```bash # Create a worktree for a feature branch git worktree add ../project-feature-a feature/task-creation git worktree add ../project-feature-b feature/user-settings # Each worktree is a separate directory with its own branch # Agents can work in parallel without interfering ls ../ project/ ← main branch project-feature-a/ ← task-creation branch project-feature-b/ ← user-settings branch # When done, merge and clean up git worktree remove ../project-feature-a ``` Benefits: - Multiple agents can work on different features simultaneously - No branch switching needed (each directory has its own branch) - If one experiment fails, delete the worktree — nothing is lost - Changes are isolated until explicitly merged ## The Save Point Pattern ``` Agent starts work │ ├── Makes a change │ ├── Test passes? → Commit → Continue │ └── Test fails? → Revert to last commit → Investigate │ ├── Makes another change │ ├── Test passes? → Commit → Continue │ └── Test fails? → Revert to last commit → Investigate │ └── Feature complete → All commits form a clean history ``` This pattern means you never lose more than one increment of work. If an agent goes off the rails, `git reset --hard HEAD` takes you back to the last successful state. ## Change Summaries After any modification, provide a structured summary. This makes review easier, documents scope discipline, and surfaces unintended changes: ``` CHANGES MADE: - src/routes/tasks.ts: Added validation middleware to POST endpoint - src/lib/validation.ts: Added TaskCreateSchema using Zod THINGS I DIDN'T TOUCH (intentionally): - src/routes/auth.ts: Has similar validation gap but out of scope - src/middleware/error.ts: Error format could be improved (separate task) POTENTIAL CONCERNS: - The Zod schema is strict — rejects extra fields. Confirm this is desired. - Added zod as a dependency (72KB gzipped) — already in package.json ``` This pattern catches wrong assumptions early and gives reviewers a clear map of the change. The "DIDN'T TOUCH" section is especially important — it shows you exercised scope discipline and didn't go on an unsolicited renovation. ## Pre-Commit Hygiene Before every commit: ```bash # 1. Check what you're about to commit git diff --staged # 2. Ensure no secrets git diff --staged | grep -i "password\|secret\|api_key\|token" # 3. Run tests npm test # 4. Run linting npm run lint # 5. Run type checking npx tsc --noEmit ``` Automate this with git hooks: ```json // package.json (using lint-staged + husky) { "lint-staged": { "*.{ts,tsx}": ["eslint --fix", "prettier --write"], "*.{json,md}": ["prettier --write"] } } ``` ## Handling Generated Files - **Commit generated files** only if the project expects them (e.g., `package-lock.json`, Prisma migrations) - **Don't commit** build output (`dist/`, `.next/`), environment files (`.env`), or IDE config (`.vscode/settings.json` unless shared) - **Always have a `.gitignore`** that covers: `node_modules/`, `dist/`, `.env`, `.env.local`, `*.pem` ## Using Git for Debugging ```bash # Find which commit introduced a bug git bisect start git bisect bad HEAD git bisect good # Git checkouts midpoints; run your test at each to narrow down # View what changed recently git log --oneline -20 git diff HEAD~5..HEAD -- src/ # Find who last changed a specific line git blame src/services/task.ts # Search commit messages for a keyword git log --grep="validation" --oneline ``` ## Common Rationalizations | Rationalization | Reality | |---|---| | "I'll commit when the feature is done" | One giant commit is impossible to review, debug, or revert. Commit each slice. | | "The message doesn't matter" | Messages are documentation. Future you (and future agents) will need to understand what changed and why. | | "I'll squash it all later" | Squashing destroys the development narrative. Prefer clean incremental commits from the start. | | "Branches add overhead" | Branches are free and prevent conflicting work from colliding. Use them. | | "I don't need a .gitignore" | Until `.env` with production secrets gets committed. Set it up immediately. | ## Red Flags - Large uncommitted changes accumulating - Commit messages like "fix", "update", "misc" - Formatting changes mixed with behavior changes - No `.gitignore` in the project - Committing `node_modules/`, `.env`, or build artifacts - Long-lived branches that diverge significantly from main - Force-pushing to shared branches ## Verification For every commit: - [ ] Commit does one logical thing - [ ] Message explains the why, follows type conventions - [ ] Tests pass before committing - [ ] No secrets in the diff - [ ] No formatting-only changes mixed with behavior changes - [ ] `.gitignore` covers standard exclusions