#!/bin/bash # Patch apllying tool template # v0.1.2 # (c) Copyright 2013. Magento Inc. # # DO NOT CHANGE ANY LINE IN THIS FILE. # 1. Check required system tools _check_installed_tools() { local missed="" until [ -z "$1" ]; do type -t $1 >/dev/null 2>/dev/null if (( $? != 0 )); then missed="$missed $1" fi shift done echo $missed } REQUIRED_UTILS='sed patch' MISSED_REQUIRED_TOOLS=`_check_installed_tools $REQUIRED_UTILS` if (( `echo $MISSED_REQUIRED_TOOLS | wc -w` > 0 )); then echo -e "Error! Some required system tools, that are utilized in this sh script, are not installed:\nTool(s) \"$MISSED_REQUIRED_TOOLS\" is(are) missed, please install it(them)." exit 1 fi # 2. Determine bin path for system tools CAT_BIN=`which cat` PATCH_BIN=`which patch` SED_BIN=`which sed` PWD_BIN=`which pwd` BASENAME_BIN=`which basename` BASE_NAME=`$BASENAME_BIN "$0"` # 3. Help menu if [ "$1" = "-?" -o "$1" = "-h" -o "$1" = "--help" ] then $CAT_BIN << EOFH Usage: sh $BASE_NAME [--help] [-R|--revert] [--list] Apply embedded patch. -R, --revert Revert previously applied embedded patch --list Show list of applied patches --help Show this help message EOFH exit 0 fi # 4. Get "revert" flag and "list applied patches" flag REVERT_FLAG= SHOW_APPLIED_LIST=0 if [ "$1" = "-R" -o "$1" = "--revert" ] then REVERT_FLAG=-R fi if [ "$1" = "--list" ] then SHOW_APPLIED_LIST=1 fi # 5. File pathes CURRENT_DIR=`$PWD_BIN`/ APP_ETC_DIR=`echo "$CURRENT_DIR""app/etc/"` APPLIED_PATCHES_LIST_FILE=`echo "$APP_ETC_DIR""applied.patches.list"` # 6. Show applied patches list if requested if [ "$SHOW_APPLIED_LIST" -eq 1 ] ; then echo -e "Applied/reverted patches list:" if [ -e "$APPLIED_PATCHES_LIST_FILE" ] then if [ ! -r "$APPLIED_PATCHES_LIST_FILE" ] then echo "ERROR: \"$APPLIED_PATCHES_LIST_FILE\" must be readable so applied patches list can be shown." exit 1 else $SED_BIN -n "/SUP-\|SUPEE-/p" $APPLIED_PATCHES_LIST_FILE fi else echo "" fi exit 0 fi # 7. Check applied patches track file and its directory _check_files() { if [ ! -e "$APP_ETC_DIR" ] then echo "ERROR: \"$APP_ETC_DIR\" must exist for proper tool work." exit 1 fi if [ ! -w "$APP_ETC_DIR" ] then echo "ERROR: \"$APP_ETC_DIR\" must be writeable for proper tool work." exit 1 fi if [ -e "$APPLIED_PATCHES_LIST_FILE" ] then if [ ! -w "$APPLIED_PATCHES_LIST_FILE" ] then echo "ERROR: \"$APPLIED_PATCHES_LIST_FILE\" must be writeable for proper tool work." exit 1 fi fi } _check_files # 8. Apply/revert patch # Note: there is no need to check files permissions for files to be patched. # "patch" tool will not modify any file if there is not enough permissions for all files to be modified. # Get start points for additional information and patch data SKIP_LINES=$((`$SED_BIN -n "/^__PATCHFILE_FOLLOWS__$/=" "$CURRENT_DIR""$BASE_NAME"` + 1)) ADDITIONAL_INFO_LINE=$(($SKIP_LINES - 3))p _apply_revert_patch() { DRY_RUN_FLAG= if [ "$1" = "dry-run" ] then DRY_RUN_FLAG=" --dry-run" echo "Checking if patch can be applied/reverted successfully..." fi PATCH_APPLY_REVERT_RESULT=`$SED_BIN -e '1,/^__PATCHFILE_FOLLOWS__$/d' "$CURRENT_DIR""$BASE_NAME" | $PATCH_BIN $DRY_RUN_FLAG $REVERT_FLAG -p0` PATCH_APPLY_REVERT_STATUS=$? if [ $PATCH_APPLY_REVERT_STATUS -eq 1 ] ; then echo -e "ERROR: Patch can't be applied/reverted successfully.\n\n$PATCH_APPLY_REVERT_RESULT" exit 1 fi if [ $PATCH_APPLY_REVERT_STATUS -eq 2 ] ; then echo -e "ERROR: Patch can't be applied/reverted successfully." exit 2 fi } REVERTED_PATCH_MARK= if [ -n "$REVERT_FLAG" ] then REVERTED_PATCH_MARK=" | REVERTED" fi _apply_revert_patch dry-run _apply_revert_patch # 9. Track patch applying result echo "Patch was applied/reverted successfully." ADDITIONAL_INFO=`$SED_BIN -n ""$ADDITIONAL_INFO_LINE"" "$CURRENT_DIR""$BASE_NAME"` APPLIED_REVERTED_ON_DATE=`date -u +"%F %T UTC"` APPLIED_REVERTED_PATCH_INFO=`echo -n "$APPLIED_REVERTED_ON_DATE"" | ""$ADDITIONAL_INFO""$REVERTED_PATCH_MARK"` echo -e "$APPLIED_REVERTED_PATCH_INFO\n$PATCH_APPLY_REVERT_RESULT\n\n" >> "$APPLIED_PATCHES_LIST_FILE" exit 0 SUPEE-11086 | CE_1.6.2.0 | v1 | 5a37fa7b6e8cfac7bb599063b4b80f20369d9da8 | Fri Mar 22 18:40:44 2019 +0000 | 4858112f5f08d7b906b38c344e355f09ad204bbe..HEAD __PATCHFILE_FOLLOWS__ diff --git app/Mage.php app/Mage.php index 86746dc4a97..ae5a3e519b3 100644 --- app/Mage.php +++ app/Mage.php @@ -727,16 +727,22 @@ final class Mage static $loggers = array(); $level = is_null($level) ? Zend_Log::DEBUG : $level; - $file = empty($file) ? 'system.log' : basename($file); + $file = empty($file) ? + (string) self::getConfig()->getNode('dev/log/file', Mage_Core_Model_Store::DEFAULT_CODE) : basename($file); // Validate file extension before save. Allowed file extensions: log, txt, html, csv - if (!self::helper('log')->isLogFileExtensionValid($file)) { + $_allowedFileExtensions = explode( + ',', + (string) self::getConfig()->getNode('dev/log/allowedFileExtensions', Mage_Core_Model_Store::DEFAULT_CODE) + ); + $logValidator = new Zend_Validate_File_Extension($_allowedFileExtensions); + $logDir = self::getBaseDir('var') . DS . 'log'; + if (!$logValidator->isValid($logDir . DS . $file)) { return; } try { if (!isset($loggers[$file])) { - $logDir = self::getBaseDir('var') . DS . 'log'; $logFile = $logDir . DS . $file; if (!is_dir($logDir)) { diff --git app/code/core/Mage/Admin/Model/Session.php app/code/core/Mage/Admin/Model/Session.php index 6832ebd0c01..899502e8940 100644 --- app/code/core/Mage/Admin/Model/Session.php +++ app/code/core/Mage/Admin/Model/Session.php @@ -158,15 +158,13 @@ class Mage_Admin_Model_Session extends Mage_Core_Model_Session_Abstract $e->setMessage( Mage::helper('adminhtml')->__('You did not sign in correctly or your account is temporarily disabled.') ); - Mage::dispatchEvent('admin_session_user_login_failed', - array('user_name' => $username, 'exception' => $e)); - if ($request && !$request->getParam('messageSent')) { - Mage::getSingleton('adminhtml/session')->addError($e->getMessage()); - $request->setParam('messageSent', true); - } + $this->_loginFailed($e, $request, $username, $e->getMessage()); + } catch (Exception $e) { + $message = Mage::helper('adminhtml')->__('An error occurred while logging in.'); + $this->_loginFailed($e, $request, $username, $message); } - return $user; + return isset($user) ? $user : null; } /** @@ -277,4 +275,29 @@ class Mage_Admin_Model_Session extends Mage_Core_Model_Session_Abstract return null; } } + + /** + * Login failed process + * + * @param Exception $e + * @param string $username + * @param string $message + * @param Mage_Core_Controller_Request_Http $request + * @return void + */ + protected function _loginFailed($e, $request, $username, $message) + { + try { + Mage::dispatchEvent('admin_session_user_login_failed', array( + 'user_name' => $username, + 'exception' => $e + )); + } catch (Exception $e) { + } + + if ($request && !$request->getParam('messageSent')) { + Mage::getSingleton('adminhtml/session')->addError($message); + $request->setParam('messageSent', true); + } + } } diff --git app/code/core/Mage/Adminhtml/Block/Api/Buttons.php app/code/core/Mage/Adminhtml/Block/Api/Buttons.php index a3a93fa1a74..b413c2fa467 100644 --- app/code/core/Mage/Adminhtml/Block/Api/Buttons.php +++ app/code/core/Mage/Adminhtml/Block/Api/Buttons.php @@ -65,7 +65,7 @@ class Mage_Adminhtml_Block_Api_Buttons extends Mage_Adminhtml_Block_Template $this->getLayout()->createBlock('adminhtml/widget_button') ->setData(array( 'label' => Mage::helper('adminhtml')->__('Delete Role'), - 'onclick' => 'deleteConfirm(\'' . Mage::helper('adminhtml')->__('Are you sure you want to do this?') . '\', \'' . $this->getUrl('*/*/delete', array('rid' => $this->getRequest()->getParam('rid'))) . '\')', + 'onclick' => 'deleteConfirm(\'' . Mage::helper('adminhtml')->__('Are you sure you want to do this?') . '\', \'' . $this->getUrlSecure('*/*/delete', array('rid' => $this->getRequest()->getParam('rid'))) . '\')', 'class' => 'delete' )) ); diff --git app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit.php app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit.php index 532dc031f72..71f470c9c6b 100644 --- app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit.php +++ app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit.php @@ -199,7 +199,7 @@ class Mage_Adminhtml_Block_Catalog_Product_Edit extends Mage_Adminhtml_Block_Wid public function getDeleteUrl() { - return $this->getUrl('*/*/delete', array('_current'=>true)); + return $this->getUrlSecure('*/*/delete', array('_current'=>true)); } public function getDuplicateUrl() diff --git app/code/core/Mage/Adminhtml/Block/Customer/Group/Edit.php app/code/core/Mage/Adminhtml/Block/Customer/Group/Edit.php index cc94481e41c..d7a584aee74 100644 --- app/code/core/Mage/Adminhtml/Block/Customer/Group/Edit.php +++ app/code/core/Mage/Adminhtml/Block/Customer/Group/Edit.php @@ -57,7 +57,7 @@ class Mage_Adminhtml_Block_Customer_Group_Edit extends Mage_Adminhtml_Block_Widg 'form_key' => Mage::getSingleton('core/session')->getFormKey() )); } else { - parent::getDeleteUrl(); + return parent::getDeleteUrl(); } } diff --git app/code/core/Mage/Adminhtml/Block/Permissions/Buttons.php app/code/core/Mage/Adminhtml/Block/Permissions/Buttons.php index 776cda97f5a..d2c9d905ef5 100644 --- app/code/core/Mage/Adminhtml/Block/Permissions/Buttons.php +++ app/code/core/Mage/Adminhtml/Block/Permissions/Buttons.php @@ -65,7 +65,7 @@ class Mage_Adminhtml_Block_Permissions_Buttons extends Mage_Adminhtml_Block_Temp $this->getLayout()->createBlock('adminhtml/widget_button') ->setData(array( 'label' => Mage::helper('adminhtml')->__('Delete Role'), - 'onclick' => 'deleteConfirm(\'' . Mage::helper('adminhtml')->__('Are you sure you want to do this?') . '\', \'' . $this->getUrl('*/*/delete', array('rid' => $this->getRequest()->getParam('rid'))) . '\')', + 'onclick' => 'deleteConfirm(\'' . Mage::helper('adminhtml')->__('Are you sure you want to do this?') . '\', \'' . $this->getUrlSecure('*/*/delete', array('rid' => $this->getRequest()->getParam('rid'))) . '\')', 'class' => 'delete' )) ); diff --git app/code/core/Mage/Adminhtml/Block/System/Design/Edit.php app/code/core/Mage/Adminhtml/Block/System/Design/Edit.php index c8a5e6835cb..f630d853437 100644 --- app/code/core/Mage/Adminhtml/Block/System/Design/Edit.php +++ app/code/core/Mage/Adminhtml/Block/System/Design/Edit.php @@ -71,7 +71,10 @@ class Mage_Adminhtml_Block_System_Design_Edit extends Mage_Adminhtml_Block_Widge public function getDeleteUrl() { - return $this->getUrl('*/*/delete', array('_current'=>true)); + return $this->getUrlSecure('*/*/delete', array( + 'id' => $this->getDesignChangeId(), + Mage_Core_Model_Url::FORM_KEY => $this->getFormKey() + )); } public function getSaveUrl() diff --git app/code/core/Mage/Adminhtml/Block/System/Store/Edit.php app/code/core/Mage/Adminhtml/Block/System/Store/Edit.php index f3e72aa850b..bedc3f32563 100644 --- app/code/core/Mage/Adminhtml/Block/System/Store/Edit.php +++ app/code/core/Mage/Adminhtml/Block/System/Store/Edit.php @@ -40,24 +40,28 @@ class Mage_Adminhtml_Block_System_Store_Edit extends Mage_Adminhtml_Block_Widget */ public function __construct() { + $backupAvailable = + Mage::getSingleton('admin/session')->isAllowed('system/tools/backup') + && Mage::helper('core')->isModuleEnabled('Mage_Backup') + && !Mage::getStoreConfigFlag('advanced/modules_disable_output/Mage_Backup'); switch (Mage::registry('store_type')) { case 'website': $this->_objectId = 'website_id'; $saveLabel = Mage::helper('core')->__('Save Website'); $deleteLabel = Mage::helper('core')->__('Delete Website'); - $deleteUrl = $this->getUrl('*/*/deleteWebsite', array('item_id' => Mage::registry('store_data')->getId())); + $deleteUrl = $this->_getDeleteUrl(Mage::registry('store_type'), $backupAvailable); break; case 'group': $this->_objectId = 'group_id'; $saveLabel = Mage::helper('core')->__('Save Store'); $deleteLabel = Mage::helper('core')->__('Delete Store'); - $deleteUrl = $this->getUrl('*/*/deleteGroup', array('item_id' => Mage::registry('store_data')->getId())); + $deleteUrl = $this->_getDeleteUrl(Mage::registry('store_type'), $backupAvailable); break; case 'store': $this->_objectId = 'store_id'; $saveLabel = Mage::helper('core')->__('Save Store View'); $deleteLabel = Mage::helper('core')->__('Delete Store View'); - $deleteUrl = $this->getUrl('*/*/deleteStore', array('item_id' => Mage::registry('store_data')->getId())); + $deleteUrl = $this->_getDeleteUrl(Mage::registry('store_type'), $backupAvailable); break; } $this->_controller = 'system_store'; @@ -100,4 +104,29 @@ class Mage_Adminhtml_Block_System_Store_Edit extends Mage_Adminhtml_Block_Widget return Mage::registry('store_action') == 'add' ? $addLabel : $editLabel; } + + /** + * Create URL depending on backups + * + * @param string $storeType + * @param bool $backupAvailable + * @return string + */ + public function _getDeleteUrl($storeType, $backupAvailable = false) + { + $storeType = uc_words($storeType); + if ($backupAvailable) { + $deleteUrl = $this->getUrl('*/*/delete' . $storeType, array('item_id' => Mage::registry('store_data')->getId())); + } else { + $deleteUrl = $this->getUrl( + '*/*/delete' . $storeType . 'Post', + array( + 'item_id' => Mage::registry('store_data')->getId(), + 'form_key' => Mage::getSingleton('core/session')->getFormKey() + ) + ); + } + + return $deleteUrl; + } } diff --git app/code/core/Mage/Adminhtml/Controller/Action.php app/code/core/Mage/Adminhtml/Controller/Action.php index aaf508efa81..627e3a68b56 100644 --- app/code/core/Mage/Adminhtml/Controller/Action.php +++ app/code/core/Mage/Adminhtml/Controller/Action.php @@ -390,19 +390,59 @@ class Mage_Adminhtml_Controller_Action extends Mage_Core_Controller_Varien_Actio */ protected function _checkIsForcedFormKeyAction() { - return in_array($this->getRequest()->getActionName(), $this->_forcedFormKeyActions); + return in_array( + strtolower($this->getRequest()->getActionName()), + array_map('strtolower', $this->_forcedFormKeyActions) + ); } /** - * Set actions name for forced use form key + * Set actions name for forced use form key if "Secret Key to URLs" disabled * * @param array | string $actionNames - action names for forced use form key */ protected function _setForcedFormKeyActions($actionNames) { - $actionNames = (is_array($actionNames)) ? $actionNames: (array)$actionNames; - $actionNames = array_merge($this->_forcedFormKeyActions, $actionNames); - $actionNames = array_unique($actionNames); - $this->_forcedFormKeyActions = $actionNames; + if (!Mage::helper('adminhtml')->isEnabledSecurityKeyUrl()) { + $actionNames = (is_array($actionNames)) ? $actionNames: (array)$actionNames; + $actionNames = array_merge($this->_forcedFormKeyActions, $actionNames); + $actionNames = array_unique($actionNames); + $this->_forcedFormKeyActions = $actionNames; + } + } + + /** + * Validate request parameter + * + * @param string $param - request parameter + * @param string $pattern - pattern that should be contained in parameter + * + * @return bool + */ + protected function _validateRequestParam($param, $pattern = '') + { + $pattern = empty($pattern) ? '/^[a-z0-9\-\_\/]*$/si' : $pattern; + if (preg_match($pattern, $param)) { + return true; + } + return false; + } + + /** + * Validate request parameters + * + * @param array $params - array of request parameters + * @param string $pattern - pattern that should be contained in parameter + * + * @return bool + */ + protected function _validateRequestParams($params, $pattern = '') + { + foreach ($params as $param) { + if (!$this->_validateRequestParam($param, $pattern)) { + return false; + } + } + return true; } } diff --git app/code/core/Mage/Adminhtml/Helper/Data.php app/code/core/Mage/Adminhtml/Helper/Data.php index 0db41a94c6f..eb467de6611 100644 --- app/code/core/Mage/Adminhtml/Helper/Data.php +++ app/code/core/Mage/Adminhtml/Helper/Data.php @@ -37,6 +37,7 @@ class Mage_Adminhtml_Helper_Data extends Mage_Core_Helper_Abstract const XML_PATH_USE_CUSTOM_ADMIN_URL = 'default/admin/url/use_custom'; const XML_PATH_USE_CUSTOM_ADMIN_PATH = 'default/admin/url/use_custom_path'; const XML_PATH_CUSTOM_ADMIN_PATH = 'default/admin/url/custom_path'; + const XML_PATH_ADMINHTML_SECURITY_USE_FORM_KEY = 'admin/security/use_form_key'; protected $_pageHelpUrl; @@ -122,4 +123,14 @@ class Mage_Adminhtml_Helper_Data extends Mage_Core_Helper_Abstract { $value = rawurldecode($value); } + + /** + * Check if enabled "Add Secret Key to URLs" functionality + * + * @return bool + */ + public function isEnabledSecurityKeyUrl() + { + return Mage::getStoreConfigFlag(self::XML_PATH_ADMINHTML_SECURITY_USE_FORM_KEY); + } } diff --git app/code/core/Mage/Adminhtml/Model/Email/PathValidator.php app/code/core/Mage/Adminhtml/Model/Email/PathValidator.php new file mode 100644 index 00000000000..70873f9c8f1 --- /dev/null +++ app/code/core/Mage/Adminhtml/Model/Email/PathValidator.php @@ -0,0 +1,45 @@ + + */ +class Mage_Adminhtml_Model_Email_PathValidator extends Zend_Validate_Abstract +{ + /** + * Returns true if and only if $value meets the validation requirements + * If $value fails validation, then this method returns false + * + * @param mixed $value + * @return boolean + */ + public function isValid($value) + { + $pathNode = is_array($value) ? array_shift($value) : $value; + + return $this->isEncryptedNodePath($pathNode); + } + + /** + * Return bool after checking the encrypted model in the path to config node + * + * @param string $path + * @return bool + */ + protected function isEncryptedNodePath($path) + { + /** @var $configModel Mage_Adminhtml_Model_Config */ + $configModel = Mage::getSingleton('adminhtml/config'); + + return in_array((string)$path, $configModel->getEncryptedNodeEntriesPaths()); + } +} diff --git app/code/core/Mage/Adminhtml/Model/LayoutUpdate/Validator.php app/code/core/Mage/Adminhtml/Model/LayoutUpdate/Validator.php index e06af3f6af0..8d73bc1e5bc 100644 --- app/code/core/Mage/Adminhtml/Model/LayoutUpdate/Validator.php +++ app/code/core/Mage/Adminhtml/Model/LayoutUpdate/Validator.php @@ -69,6 +69,7 @@ class Mage_Adminhtml_Model_LayoutUpdate_Validator extends Zend_Validate_Abstract protected $_disallowedBlock = array( 'Mage_Install_Block_End', 'Mage_Rss_Block_Order_New', + 'Mage_Core_Block_Template_Zend', ); /** diff --git app/code/core/Mage/Adminhtml/Model/System/Config/Backend/Gatewayurl.php app/code/core/Mage/Adminhtml/Model/System/Config/Backend/Gatewayurl.php new file mode 100644 index 00000000000..d6d9bb54563 --- /dev/null +++ app/code/core/Mage/Adminhtml/Model/System/Config/Backend/Gatewayurl.php @@ -0,0 +1,35 @@ + + */ +class Mage_Adminhtml_Model_System_Config_Backend_Gatewayurl extends Mage_Core_Model_Config_Data +{ + /** + * Before save processing + * + * @throws Mage_Core_Exception + * @return Mage_Adminhtml_Model_System_Config_Backend_Gatewayurl + */ + protected function _beforeSave() + { + if ($this->getValue()) { + $parsed = parse_url($this->getValue()); + if (!isset($parsed['scheme']) || (('https' != $parsed['scheme']) && ('http' != $parsed['scheme']))) { + Mage::throwException(Mage::helper('core')->__('Invalid URL scheme.')); + } + } + + return $this; + } +} diff --git app/code/core/Mage/Adminhtml/Model/System/Config/Backend/Protected.php app/code/core/Mage/Adminhtml/Model/System/Config/Backend/Protected.php new file mode 100644 index 00000000000..15659227f53 --- /dev/null +++ app/code/core/Mage/Adminhtml/Model/System/Config/Backend/Protected.php @@ -0,0 +1,17 @@ +_setForcedFormKeyActions(array('delete', 'save')); + return parent::preDispatch(); + } protected function _initAction() { diff --git app/code/core/Mage/Adminhtml/controllers/Api/UserController.php app/code/core/Mage/Adminhtml/controllers/Api/UserController.php index 5931e6f5ed2..04f68cdc7a2 100644 --- app/code/core/Mage/Adminhtml/controllers/Api/UserController.php +++ app/code/core/Mage/Adminhtml/controllers/Api/UserController.php @@ -25,6 +25,16 @@ */ class Mage_Adminhtml_Api_UserController extends Mage_Adminhtml_Controller_Action { + /** + * Controller predispatch method + * + * @return Mage_Adminhtml_Controller_Action + */ + public function preDispatch() + { + $this->_setForcedFormKeyActions('delete'); + return parent::preDispatch(); + } protected function _initAction() { diff --git app/code/core/Mage/Adminhtml/controllers/Catalog/Product/Action/AttributeController.php app/code/core/Mage/Adminhtml/controllers/Catalog/Product/Action/AttributeController.php index 41e364e569e..04a0a477800 100644 --- app/code/core/Mage/Adminhtml/controllers/Catalog/Product/Action/AttributeController.php +++ app/code/core/Mage/Adminhtml/controllers/Catalog/Product/Action/AttributeController.php @@ -62,6 +62,7 @@ class Mage_Adminhtml_Catalog_Product_Action_AttributeController extends Mage_Adm $attributesData = $this->getRequest()->getParam('attributes', array()); $websiteRemoveData = $this->getRequest()->getParam('remove_website_ids', array()); $websiteAddData = $this->getRequest()->getParam('add_website_ids', array()); + $attributeName = ''; /* Prepare inventory data item options (use config settings) */ foreach (Mage::helper('cataloginventory')->getConfigItemOptions() as $option) { @@ -74,6 +75,7 @@ class Mage_Adminhtml_Catalog_Product_Action_AttributeController extends Mage_Adm if ($attributesData) { $dateFormat = Mage::app()->getLocale()->getDateFormat(Mage_Core_Model_Locale::FORMAT_TYPE_SHORT); $storeId = $this->_getHelper()->getSelectedStoreId(); + $data = new Varien_Object(); foreach ($attributesData as $attributeCode => $value) { $attribute = Mage::getSingleton('eav/config') @@ -82,6 +84,9 @@ class Mage_Adminhtml_Catalog_Product_Action_AttributeController extends Mage_Adm unset($attributesData[$attributeCode]); continue; } + $data->setData($attributeCode, $value); + $attributeName = $attribute->getFrontendLabel(); + $attribute->getBackend()->validate($data); if ($attribute->getBackendType() == 'datetime') { if (!empty($value)) { $filterInput = new Zend_Filter_LocalizedToNormalized(array( @@ -167,6 +172,9 @@ class Mage_Adminhtml_Catalog_Product_Action_AttributeController extends Mage_Adm count($this->_getHelper()->getProductIds())) ); } + catch (Mage_Eav_Model_Entity_Attribute_Exception $e) { + $this->_getSession()->addError($attributeName . ': ' . $e->getMessage()); + } catch (Mage_Core_Exception $e) { $this->_getSession()->addError($e->getMessage()); } diff --git app/code/core/Mage/Adminhtml/controllers/Catalog/Product/AttributeController.php app/code/core/Mage/Adminhtml/controllers/Catalog/Product/AttributeController.php index 90af67c2d1a..720d5ed08f4 100644 --- app/code/core/Mage/Adminhtml/controllers/Catalog/Product/AttributeController.php +++ app/code/core/Mage/Adminhtml/controllers/Catalog/Product/AttributeController.php @@ -39,6 +39,7 @@ class Mage_Adminhtml_Catalog_Product_AttributeController extends Mage_Adminhtml_ public function preDispatch() { + $this->_setForcedFormKeyActions('delete'); parent::preDispatch(); $this->_entityTypeId = Mage::getModel('eav/entity')->setType(Mage_Catalog_Model_Product::ENTITY)->getTypeId(); } @@ -200,7 +201,7 @@ class Mage_Adminhtml_Catalog_Product_AttributeController extends Mage_Adminhtml_ //validate attribute_code if (isset($data['attribute_code'])) { - $validatorAttrCode = new Zend_Validate_Regex(array('pattern' => '/^[a-z][a-z_0-9]{1,254}$/')); + $validatorAttrCode = new Zend_Validate_Regex(array('pattern' => '/^(?!event$)[a-z][a-z_0-9]{1,254}$/')); if (!$validatorAttrCode->isValid($data['attribute_code'])) { $session->addError( $helper->__('Attribute code is invalid. Please use only letters (a-z), numbers (0-9) or underscore(_) in this field, first character should be a letter.')); diff --git app/code/core/Mage/Adminhtml/controllers/Catalog/Product/WidgetController.php app/code/core/Mage/Adminhtml/controllers/Catalog/Product/WidgetController.php index 5c345ae6d6e..e5c78668596 100644 --- app/code/core/Mage/Adminhtml/controllers/Catalog/Product/WidgetController.php +++ app/code/core/Mage/Adminhtml/controllers/Catalog/Product/WidgetController.php @@ -36,6 +36,9 @@ class Mage_Adminhtml_Catalog_Product_WidgetController extends Mage_Adminhtml_Con { /** * Chooser Source action + * + * @throws Mage_Core_Exception + * @return void */ public function chooserAction() { @@ -43,6 +46,10 @@ class Mage_Adminhtml_Catalog_Product_WidgetController extends Mage_Adminhtml_Con $massAction = $this->getRequest()->getParam('use_massaction', false); $productTypeId = $this->getRequest()->getParam('product_type_id', null); + if (!$this->_validateRequestParam($uniqId)) { + Mage::throwException(Mage::helper('adminhtml')->__('An error occurred while adding condition.')); + } + $productsGrid = $this->getLayout()->createBlock('adminhtml/catalog_product_widget_chooser', '', array( 'id' => $uniqId, 'use_massaction' => $massAction, diff --git app/code/core/Mage/Adminhtml/controllers/Catalog/ProductController.php app/code/core/Mage/Adminhtml/controllers/Catalog/ProductController.php index 61641e264c3..c804de879a0 100644 --- app/code/core/Mage/Adminhtml/controllers/Catalog/ProductController.php +++ app/code/core/Mage/Adminhtml/controllers/Catalog/ProductController.php @@ -45,6 +45,17 @@ class Mage_Adminhtml_Catalog_ProductController extends Mage_Adminhtml_Controller */ protected $_publicActions = array('edit'); + /** + * Controller predispatch method + * + * @return Mage_Adminhtml_Controller_Action + */ + public function preDispatch() + { + $this->_setForcedFormKeyActions(array('delete', 'massDelete')); + return parent::preDispatch(); + } + protected function _construct() { // Define module dependent translate diff --git app/code/core/Mage/Adminhtml/controllers/Cms/WysiwygController.php app/code/core/Mage/Adminhtml/controllers/Cms/WysiwygController.php index 42792cbdd7b..a2441922c3f 100644 --- app/code/core/Mage/Adminhtml/controllers/Cms/WysiwygController.php +++ app/code/core/Mage/Adminhtml/controllers/Cms/WysiwygController.php @@ -44,6 +44,10 @@ class Mage_Adminhtml_Cms_WysiwygController extends Mage_Adminhtml_Controller_Act $directive = Mage::helper('core')->urlDecode($directive); $url = Mage::getModel('core/email_template_filter')->filter($directive); try { + $allowedStreamWrappers = Mage::helper('cms')->getAllowedStreamWrappers(); + if (!Mage::getModel('core/file_validator_streamWrapper', $allowedStreamWrappers)->validate($url)) { + Mage::throwException(Mage::helper('core')->__('Invalid stream.')); + } $image = Varien_Image_Adapter::factory('GD2'); $image->open($url); } catch (Exception $e) { diff --git app/code/core/Mage/Adminhtml/controllers/CustomerController.php app/code/core/Mage/Adminhtml/controllers/CustomerController.php index a3bad1c5d1d..dc6ade7ab1a 100644 --- app/code/core/Mage/Adminhtml/controllers/CustomerController.php +++ app/code/core/Mage/Adminhtml/controllers/CustomerController.php @@ -40,7 +40,7 @@ class Mage_Adminhtml_CustomerController extends Mage_Adminhtml_Controller_Action */ public function preDispatch() { - $this->_setForcedFormKeyActions('delete'); + $this->_setForcedFormKeyActions(array('delete', 'massDelete')); return parent::preDispatch(); } diff --git app/code/core/Mage/Adminhtml/controllers/Permissions/RoleController.php app/code/core/Mage/Adminhtml/controllers/Permissions/RoleController.php index 7e8efef4108..fd6343ddcc7 100644 --- app/code/core/Mage/Adminhtml/controllers/Permissions/RoleController.php +++ app/code/core/Mage/Adminhtml/controllers/Permissions/RoleController.php @@ -34,6 +34,17 @@ class Mage_Adminhtml_Permissions_RoleController extends Mage_Adminhtml_Controller_Action { + /** + * Controller predispatch method + * + * @return Mage_Adminhtml_Controller_Action + */ + public function preDispatch() + { + $this->_setForcedFormKeyActions('delete'); + return parent::preDispatch(); + } + /** * Preparing layout for output * @@ -138,6 +149,13 @@ class Mage_Adminhtml_Permissions_RoleController extends Mage_Adminhtml_Controlle { $rid = $this->getRequest()->getParam('rid', false); + $role = $this->_initRole(); + if (!$role->getId()) { + Mage::getSingleton('adminhtml/session')->addError($this->__('This Role no longer exists.')); + $this->_redirect('*/*/'); + return; + } + $currentUser = Mage::getModel('admin/user')->setId(Mage::getSingleton('admin/session')->getUser()->getId()); if (in_array($rid, $currentUser->getRoles()) ) { @@ -147,7 +165,7 @@ class Mage_Adminhtml_Permissions_RoleController extends Mage_Adminhtml_Controlle } try { - $role = $this->_initRole()->delete(); + $role->delete(); Mage::getSingleton('adminhtml/session')->addSuccess($this->__('The role has been deleted.')); } catch (Exception $e) { diff --git app/code/core/Mage/Adminhtml/controllers/Permissions/UserController.php app/code/core/Mage/Adminhtml/controllers/Permissions/UserController.php index 79665cc138c..7fd0f7841a1 100644 --- app/code/core/Mage/Adminhtml/controllers/Permissions/UserController.php +++ app/code/core/Mage/Adminhtml/controllers/Permissions/UserController.php @@ -25,6 +25,16 @@ */ class Mage_Adminhtml_Permissions_UserController extends Mage_Adminhtml_Controller_Action { + /** + * Controller predispatch method + * + * @return Mage_Adminhtml_Controller_Action + */ + public function preDispatch() + { + $this->_setForcedFormKeyActions('delete'); + return parent::preDispatch(); + } protected function _initAction() { diff --git app/code/core/Mage/Adminhtml/controllers/Promo/CatalogController.php app/code/core/Mage/Adminhtml/controllers/Promo/CatalogController.php index 1141958a1ee..3775fe7920e 100644 --- app/code/core/Mage/Adminhtml/controllers/Promo/CatalogController.php +++ app/code/core/Mage/Adminhtml/controllers/Promo/CatalogController.php @@ -33,6 +33,17 @@ */ class Mage_Adminhtml_Promo_CatalogController extends Mage_Adminhtml_Controller_Action { + /** + * Controller predispatch method + * + * @return Mage_Adminhtml_Controller_Action + */ + public function preDispatch() + { + $this->_setForcedFormKeyActions('delete'); + return parent::preDispatch(); + } + protected function _initAction() { $this->loadLayout() @@ -187,6 +198,13 @@ class Mage_Adminhtml_Promo_CatalogController extends Mage_Adminhtml_Controller_A try { $model = Mage::getModel('catalogrule/rule'); $model->load($id); + if (!$model->getRuleId()) { + Mage::getSingleton('adminhtml/session')->addError( + Mage::helper('catalogrule')->__('Unable to find a rule to delete.') + ); + $this->_redirect('*/*/'); + return; + } $model->delete(); Mage::app()->saveCache(1, 'catalog_rules_dirty'); Mage::getSingleton('adminhtml/session')->addSuccess( diff --git app/code/core/Mage/Adminhtml/controllers/Promo/QuoteController.php app/code/core/Mage/Adminhtml/controllers/Promo/QuoteController.php index d2d16501ca1..deb0cf5589d 100644 --- app/code/core/Mage/Adminhtml/controllers/Promo/QuoteController.php +++ app/code/core/Mage/Adminhtml/controllers/Promo/QuoteController.php @@ -27,6 +27,18 @@ class Mage_Adminhtml_Promo_QuoteController extends Mage_Adminhtml_Controller_Action { + /** + * Controller predispatch method + * + * @return Mage_Adminhtml_Controller_Action + */ + + public function preDispatch() + { + $this->_setForcedFormKeyActions('delete'); + return parent::preDispatch(); + } + protected function _initRule() { $this->_title($this->__('Promotions'))->_title($this->__('Shopping Cart Price Rules')); @@ -190,6 +202,15 @@ class Mage_Adminhtml_Promo_QuoteController extends Mage_Adminhtml_Controller_Act try { $model = Mage::getModel('salesrule/rule'); $model->load($id); + + if (!$model->getRuleId()) { + Mage::getSingleton('adminhtml/session')->addError( + Mage::helper('catalogrule')->__('Unable to find a rule to delete.') + ); + $this->_redirect('*/*/'); + return; + } + $model->delete(); Mage::getSingleton('adminhtml/session')->addSuccess( Mage::helper('salesrule')->__('The rule has been deleted.')); @@ -210,12 +231,25 @@ class Mage_Adminhtml_Promo_QuoteController extends Mage_Adminhtml_Controller_Act $this->_redirect('*/*/'); } + /** + * New condition HTML action + * + * @throws Mage_Core_Exception + * @return void + */ public function newConditionHtmlAction() { $id = $this->getRequest()->getParam('id'); $typeArr = explode('|', str_replace('-', '/', $this->getRequest()->getParam('type'))); $type = $typeArr[0]; + if (!$this->_validateRequestParams(array($id, $type))) { + if ($this->getRequest()->getQuery('id')) { + $this->getRequest()->setQuery('id', ''); + } + Mage::throwException(Mage::helper('adminhtml')->__('An error occurred while adding condition.')); + } + $model = Mage::getModel($type) ->setId($id) ->setType($type) diff --git app/code/core/Mage/Adminhtml/controllers/System/BackupController.php app/code/core/Mage/Adminhtml/controllers/System/BackupController.php index 3cfa65dd051..a78d332a3f6 100644 --- app/code/core/Mage/Adminhtml/controllers/System/BackupController.php +++ app/code/core/Mage/Adminhtml/controllers/System/BackupController.php @@ -40,7 +40,7 @@ class Mage_Adminhtml_System_BackupController extends Mage_Adminhtml_Controller_A */ public function preDispatch() { - $this->_setForcedFormKeyActions('create'); + $this->_setForcedFormKeyActions(array('create', 'massDelete')); return parent::preDispatch(); } diff --git app/code/core/Mage/Adminhtml/controllers/System/DesignController.php app/code/core/Mage/Adminhtml/controllers/System/DesignController.php index d1a4ca900bb..ae6592e2656 100644 --- app/code/core/Mage/Adminhtml/controllers/System/DesignController.php +++ app/code/core/Mage/Adminhtml/controllers/System/DesignController.php @@ -27,6 +27,17 @@ class Mage_Adminhtml_System_DesignController extends Mage_Adminhtml_Controller_Action { + /** + * Controller predispatch method + * + * @return Mage_Adminhtml_Controller_Action + */ + public function preDispatch() + { + $this->_setForcedFormKeyActions('delete'); + return parent::preDispatch(); + } + public function indexAction() { $this->_title($this->__('System'))->_title($this->__('Design')); diff --git app/code/core/Mage/Catalog/Model/Product/Option/Type/Select.php app/code/core/Mage/Catalog/Model/Product/Option/Type/Select.php index f620bb624fd..9d6c3d29c5b 100644 --- app/code/core/Mage/Catalog/Model/Product/Option/Type/Select.php +++ app/code/core/Mage/Catalog/Model/Product/Option/Type/Select.php @@ -54,7 +54,8 @@ class Mage_Catalog_Model_Product_Option_Type_Select extends Mage_Catalog_Model_P if (!$this->_isSingleSelection()) { $valuesCollection = $option->getOptionValuesByOptionId($value, $this->getProduct()->getStoreId()) ->load(); - if ($valuesCollection->count() != count($value)) { + $valueCount = empty($value) ? 0 : count($value); + if ($valuesCollection->count() != $valueCount) { $this->setIsValid(false); Mage::throwException(Mage::helper('catalog')->__('Please specify the product required option(s).')); } diff --git app/code/core/Mage/Cms/Helper/Data.php app/code/core/Mage/Cms/Helper/Data.php index ac81ca9d545..23f14ed7578 100644 --- app/code/core/Mage/Cms/Helper/Data.php +++ app/code/core/Mage/Cms/Helper/Data.php @@ -36,6 +36,7 @@ class Mage_Cms_Helper_Data extends Mage_Core_Helper_Abstract { const XML_NODE_PAGE_TEMPLATE_FILTER = 'global/cms/page/tempate_filter'; const XML_NODE_BLOCK_TEMPLATE_FILTER = 'global/cms/block/tempate_filter'; + const XML_NODE_ALLOWED_STREAM_WRAPPERS = 'global/cms/allowed_stream_wrappers'; /** * Retrieve Template processor for Page Content @@ -58,4 +59,19 @@ class Mage_Cms_Helper_Data extends Mage_Core_Helper_Abstract $model = (string)Mage::getConfig()->getNode(self::XML_NODE_BLOCK_TEMPLATE_FILTER); return Mage::getModel($model); } + + /** + * Return list with allowed stream wrappers + * + * @return array + */ + public function getAllowedStreamWrappers() + { + $allowedStreamWrappers = Mage::getConfig()->getNode(self::XML_NODE_ALLOWED_STREAM_WRAPPERS); + if ($allowedStreamWrappers instanceof Mage_Core_Model_Config_Element) { + $allowedStreamWrappers = $allowedStreamWrappers->asArray(); + } + + return is_array($allowedStreamWrappers) ? $allowedStreamWrappers : array(); + } } diff --git app/code/core/Mage/Cms/etc/config.xml app/code/core/Mage/Cms/etc/config.xml index 6e39c5b5a71..4bc0263ef9b 100644 --- app/code/core/Mage/Cms/etc/config.xml +++ app/code/core/Mage/Cms/etc/config.xml @@ -190,6 +190,10 @@ cms/template_filter + + http + https + diff --git app/code/core/Mage/Core/Block/Abstract.php app/code/core/Mage/Core/Block/Abstract.php index 7d9d714c7d7..98211203919 100644 --- app/code/core/Mage/Core/Block/Abstract.php +++ app/code/core/Mage/Core/Block/Abstract.php @@ -947,6 +947,22 @@ abstract class Mage_Core_Block_Abstract extends Varien_Object return $this->_getUrlModel()->getUrl($route, $params); } + /** + * Generate security url by route and parameters (add form key if "Add Secret Key to URLs" disabled) + * + * @param string $route + * @param array $params + * + * @return string + */ + public function getUrlSecure($route = '', $params = array()) + { + if (!Mage::helper('adminhtml')->isEnabledSecurityKeyUrl()) { + $params[Mage_Core_Model_Url::FORM_KEY] = $this->getFormKey(); + } + return $this->getUrl($route, $params); + } + /** * Generate base64-encoded url by route and parameters * diff --git app/code/core/Mage/Core/Helper/Abstract.php app/code/core/Mage/Core/Helper/Abstract.php index 274348aaa78..7afa6926cf4 100644 --- app/code/core/Mage/Core/Helper/Abstract.php +++ app/code/core/Mage/Core/Helper/Abstract.php @@ -271,7 +271,45 @@ abstract class Mage_Core_Helper_Abstract */ public function escapeUrl($data) { - return htmlspecialchars($data); + return htmlspecialchars( + $this->escapeScriptIdentifiers((string) $data), + ENT_COMPAT | ENT_HTML5 | ENT_HTML401, + 'UTF-8' + ); + } + + /** + * Remove `\t`,`\n`,`\r`,`\0`,`\x0B:` symbols from the string. + * + * @param string $data + * @return string + */ + public function escapeSpecial($data) + { + $specialSymbolsFiltrationPattern = '/[\t\n\r\0\x0B]+/'; + + return (string) preg_replace($specialSymbolsFiltrationPattern, '', $data); + } + + /** + * Remove `javascript:`, `vbscript:`, `data:` words from the string. + * + * @param string $data + * @return string + */ + public function escapeScriptIdentifiers($data) + { + $scripIdentifiersFiltrationPattern = '/((javascript(\\\\x3a|:|%3A))|(data(\\\\x3a|:|%3A))|(vbscript:))|' + . '((\\\\x6A\\\\x61\\\\x76\\\\x61\\\\x73\\\\x63\\\\x72\\\\x69\\\\x70\\\\x74(\\\\x3a|:|%3A))|' + . '(\\\\x64\\\\x61\\\\x74\\\\x61(\\\\x3a|:|%3A)))/i'; + + $preFilteredData = $this->escapeSpecial($data); + $filteredData = preg_replace($scripIdentifiersFiltrationPattern, ':', $preFilteredData) ?: ''; + if (preg_match($scripIdentifiersFiltrationPattern, $filteredData)) { + $filteredData = $this->escapeScriptIdentifiers($filteredData); + } + + return $filteredData; } /** diff --git app/code/core/Mage/Core/Model/File/Validator/StreamWrapper.php app/code/core/Mage/Core/Model/File/Validator/StreamWrapper.php new file mode 100644 index 00000000000..5f3752d268a --- /dev/null +++ app/code/core/Mage/Core/Model/File/Validator/StreamWrapper.php @@ -0,0 +1,51 @@ + + */ +class Mage_Core_Model_File_Validator_StreamWrapper +{ + /** + * Allowed stream wrappers + * + * @var array + */ + protected $_allowedStreamWrappers = array(); + + /** + * Mage_Core_Model_File_Validator_StreamWrapper constructor. + * + * @param array $allowedStreamWrappers + */ + public function __construct($allowedStreamWrappers = array()) + { + $this->_allowedStreamWrappers = $allowedStreamWrappers; + } + + /** + * Validation callback for checking is stream wrapper allowed + * + * @param string $filePath Path to file + * @return boolean + */ + public function validate($filePath) + { + if (($pos = strpos($filePath, '://')) > 0) { + $wrapper = substr($filePath, 0, $pos); + if (!in_array($wrapper, $this->_allowedStreamWrappers)) { + return false; + } + } + return true; + } +} diff --git app/code/core/Mage/Core/Model/Input/Filter/MaliciousCode.php app/code/core/Mage/Core/Model/Input/Filter/MaliciousCode.php index 2566189da40..07baa8523e9 100644 --- app/code/core/Mage/Core/Model/Input/Filter/MaliciousCode.php +++ app/code/core/Mage/Core/Model/Input/Filter/MaliciousCode.php @@ -50,7 +50,7 @@ class Mage_Core_Model_Input_Filter_MaliciousCode implements Zend_Filter_Interfac //js in the style attribute '/style=[^<]*((expression\s*?\([^<]*?\))|(behavior\s*:))[^<]*(?=\>)/Uis', //js attributes - '/(ondblclick|onclick|onkeydown|onkeypress|onkeyup|onmousedown|onmousemove|onmouseout|onmouseover|onmouseup|onload|onunload|onerror)\s*=[^<]*(?=\>)/Uis', + '/(ondblclick|onclick|onkeydown|onkeypress|onkeyup|onmousedown|onmousemove|onmouseout|onmouseover|onmouseup|onload|onunload|onerror)\s*=[^>]*(?=\>)/Uis', //tags '/<\/?(script|meta|link|frame|iframe).*>/Uis', //base64 usage diff --git app/code/core/Mage/Core/etc/system.xml app/code/core/Mage/Core/etc/system.xml index 550e5a05b77..0ee57baa705 100644 --- app/code/core/Mage/Core/etc/system.xml +++ app/code/core/Mage/Core/etc/system.xml @@ -738,6 +738,21 @@ + + + text + 0 + 0 + 0 + + + adminhtml/system_config_backend_protected + 0 + 0 + 0 + + + text diff --git app/code/core/Mage/Eav/Model/Attribute/Data/File.php app/code/core/Mage/Eav/Model/Attribute/Data/File.php index b336a522276..1dddac87634 100644 --- app/code/core/Mage/Eav/Model/Attribute/Data/File.php +++ app/code/core/Mage/Eav/Model/Attribute/Data/File.php @@ -184,6 +184,7 @@ class Mage_Eav_Model_Attribute_Data_File extends Mage_Eav_Model_Attribute_Data_A } if (count($errors) == 0) { + $attribute->setAttributeValidationAsPassed(); return true; } @@ -204,6 +205,10 @@ class Mage_Eav_Model_Attribute_Data_File extends Mage_Eav_Model_Attribute_Data_A } $attribute = $this->getAttribute(); + if (!$attribute->isAttributeValidationPassed()) { + return $this; + } + $original = $this->getEntity()->getData($attribute->getAttributeCode()); $toDelete = false; if ($original) { diff --git app/code/core/Mage/Eav/Model/Entity/Attribute/Abstract.php app/code/core/Mage/Eav/Model/Entity/Attribute/Abstract.php index 4d729506eb6..734cb5005a5 100644 --- app/code/core/Mage/Eav/Model/Entity/Attribute/Abstract.php +++ app/code/core/Mage/Eav/Model/Entity/Attribute/Abstract.php @@ -86,6 +86,13 @@ abstract class Mage_Eav_Model_Entity_Attribute_Abstract extends Mage_Core_Model_ */ protected $_dataTable = null; + /** + * Attribute validation flag + * + * @var boolean + */ + protected $_attributeValidationPassed = false; + /** * Initialize resource model */ @@ -121,6 +128,16 @@ abstract class Mage_Eav_Model_Entity_Attribute_Abstract extends Mage_Core_Model_ return $this; } + /** + * Mark current attribute as passed validation + * + * @return void + */ + public function setAttributeValidationAsPassed() + { + $this->_attributeValidationPassed = true; + } + /** * Retrieve attribute configuration (deprecated) * @@ -423,6 +440,16 @@ abstract class Mage_Eav_Model_Entity_Attribute_Abstract extends Mage_Core_Model_ return $isEmpty; } + /** + * Check if attribute is valid + * + * @return boolean + */ + public function isAttributeValidationPassed() + { + return $this->_attributeValidationPassed; + } + /** * Check if attribute in specified set * diff --git app/code/core/Mage/Rss/etc/system.xml app/code/core/Mage/Rss/etc/system.xml index 41df19397ba..7661de7bd75 100644 --- app/code/core/Mage/Rss/etc/system.xml +++ app/code/core/Mage/Rss/etc/system.xml @@ -141,8 +141,9 @@ 1 1 - + + Enabling can increase security risk by exposing some order details. select adminhtml/system_config_source_enabledisable 10 diff --git app/code/core/Mage/Usa/etc/system.xml app/code/core/Mage/Usa/etc/system.xml index e27ef378915..714a84fd955 100644 --- app/code/core/Mage/Usa/etc/system.xml +++ app/code/core/Mage/Usa/etc/system.xml @@ -124,6 +124,7 @@ text + adminhtml/system_config_backend_gatewayurl 20 1 1 @@ -696,6 +697,7 @@ text + adminhtml/system_config_backend_gatewayurl 40 1 1 @@ -713,6 +715,7 @@ text + adminhtml/system_config_backend_gatewayurl 30 1 1 @@ -795,7 +798,7 @@ 1 1 0 - 0 + <label>Title</label> <frontend_type>text</frontend_type> diff --git app/code/core/Mage/Widget/controllers/Adminhtml/Widget/InstanceController.php app/code/core/Mage/Widget/controllers/Adminhtml/Widget/InstanceController.php index eb880c57280..cd37e26a0ed 100644 --- app/code/core/Mage/Widget/controllers/Adminhtml/Widget/InstanceController.php +++ app/code/core/Mage/Widget/controllers/Adminhtml/Widget/InstanceController.php @@ -156,7 +156,7 @@ class Mage_Widget_Adminhtml_Widget_InstanceController extends Mage_Adminhtml_Con public function saveAction() { $widgetInstance = $this->_initWidgetInstance(); - if (!$widgetInstance) { + if (!$widgetInstance || !$this->_validatePostData($widgetInstance, $this->getRequest()->getPost())) { $this->_redirect('*/*/'); return; } @@ -309,4 +309,44 @@ class Mage_Widget_Adminhtml_Widget_InstanceController extends Mage_Adminhtml_Con } return $result; } + + /** + * Validates update xml post data + * + * @param $widgetInstance + * @param $data + * @return bool + */ + protected function _validatePostData($widgetInstance, $data) + { + $errorNo = true; + if (!empty($data['widget_instance']) && is_array($data['widget_instance'])) { + /** @var $validatorCustomLayout Mage_Adminhtml_Model_LayoutUpdate_Validator */ + $validatorCustomLayout = Mage::getModel('adminhtml/layoutUpdate_validator'); + foreach ($data['widget_instance'] as $pageGroup) { + try { + if ( + !empty($pageGroup['page_group']) + && !empty($pageGroup[$pageGroup['page_group']]['template']) + && !empty($pageGroup[$pageGroup['page_group']]['block']) + && !$validatorCustomLayout->isValid($widgetInstance->generateLayoutUpdateXml( + $pageGroup[$pageGroup['page_group']]['block'], + $pageGroup[$pageGroup['page_group']]['template'])) + ) { + $errorNo = false; + } + } catch (Exception $exception) { + Mage::logException($exception); + $this->_getSession()->addError( + $this->__('An error occurred during POST data validation: %s', $exception->getMessage()) + ); + $errorNo = false; + } + } + foreach ($validatorCustomLayout->getMessages() as $message) { + $this->_getSession()->addError($message); + } + } + return $errorNo; + } } diff --git app/etc/config.xml app/etc/config.xml index d704ba0ded0..3465d47bf72 100644 --- app/etc/config.xml +++ app/etc/config.xml @@ -140,6 +140,15 @@ <export>{{var_dir}}/export</export> </filesystem> </system> + <dev> + <template> + <allow_symlink>0</allow_symlink> + </template> + <log> + <file>system.log</file> + <allowedFileExtensions>log,txt,html,csv</allowedFileExtensions> + </log> + </dev> <general> <locale> <code>en_US</code> diff --git app/locale/en_US/Mage_Adminhtml.csv app/locale/en_US/Mage_Adminhtml.csv index 0136f9aa5d0..d2c690e94ee 100644 --- app/locale/en_US/Mage_Adminhtml.csv +++ app/locale/en_US/Mage_Adminhtml.csv @@ -100,6 +100,7 @@ "All valid rates have been saved.","All valid rates have been saved." "Amounts","Amounts" "An error has occured while syncronizing media storages.","An error has occured while syncronizing media storages." +"An error occurred while adding condition.","An error occurred while adding condition." "An error occurred while clearing the JavaScript/CSS cache.","An error occurred while clearing the JavaScript/CSS cache." "An error occurred while clearing the image cache.","An error occurred while clearing the image cache." "An error occurred while creating the backup.","An error occurred while creating the backup." @@ -110,6 +111,7 @@ "An error occurred while deleting this set.","An error occurred while deleting this set." "An error occurred while deleting this template.","An error occurred while deleting this template." "An error occurred while finishing process. Please refresh the cache","An error occurred while finishing process. Please refresh the cache" +"An error occurred while logging in.","An error occurred while logging in." "An error occurred while rebuilding the CatalogInventory Stock Status.","An error occurred while rebuilding the CatalogInventory Stock Status." "An error occurred while rebuilding the catalog index.","An error occurred while rebuilding the catalog index." "An error occurred while rebuilding the flat catalog category.","An error occurred while rebuilding the flat catalog category." diff --git app/locale/en_US/Mage_Core.csv app/locale/en_US/Mage_Core.csv index 258a5f5d420..0e1fbcb3402 100644 --- app/locale/en_US/Mage_Core.csv +++ app/locale/en_US/Mage_Core.csv @@ -136,6 +136,7 @@ "If the current frame position does not cover utmost pages, will render link to current position plus/minus this value.","If the current frame position does not cover utmost pages, will render link to current position plus/minus this value." "Incorrect credit card expiration date.","Incorrect credit card expiration date." "Input type ""%value%"" not found in the input types list.","Input type ""%value%"" not found in the input types list." +"Invalid URL scheme.","Invalid URL scheme." "Invalid base url type","Invalid base url type" "Invalid block name to set child %s: %s","Invalid block name to set child %s: %s" "Invalid block type: %s","Invalid block type: %s" @@ -143,6 +144,7 @@ "Invalid connection","Invalid connection" "Invalid layout update handle","Invalid layout update handle" "Invalid messages storage ""%s"" for layout messages initialization","Invalid messages storage ""%s"" for layout messages initialization" +"Invalid stream.","Invalid stream." "Invalid query","Invalid query" "Invalid transactional email code: ","Invalid transactional email code: " "Invalid website\'s configuration path: %s","Invalid website\'s configuration path: %s" diff --git app/locale/en_US/Mage_Rss.csv app/locale/en_US/Mage_Rss.csv index 64ae2f3a63c..815bc0dc93d 100644 --- app/locale/en_US/Mage_Rss.csv +++ app/locale/en_US/Mage_Rss.csv @@ -16,6 +16,7 @@ "Discount","Discount" "Discount (%s)","Discount (%s)" "Enable RSS","Enable RSS" +"Enabling can increase security risk by exposing some order details.", "Enabling can increase security risk by exposing some order details." "Error in processing xml. %s","Error in processing xml. %s" "From:","From:" "Get Feed","Get Feed" diff --git app/locale/en_US/Mage_Widget.csv app/locale/en_US/Mage_Widget.csv index edd41fcee7a..30fe29659e5 100644 --- app/locale/en_US/Mage_Widget.csv +++ app/locale/en_US/Mage_Widget.csv @@ -6,6 +6,7 @@ "All","All" "All Pages","All Pages" "All Product Types","All Product Types" +"An error occurred during POST data validation: %s","An error occurred during POST data validation: %s" "Anchor Categories","Anchor Categories" "Assign to Store Views","Assign to Store Views" "Big Image","Big Image" diff --git lib/Varien/Db/Adapter/Pdo/Mysql.php lib/Varien/Db/Adapter/Pdo/Mysql.php index c6f8a2b30ab..4d900ff3ee8 100644 --- lib/Varien/Db/Adapter/Pdo/Mysql.php +++ lib/Varien/Db/Adapter/Pdo/Mysql.php @@ -2662,7 +2662,7 @@ class Varien_Db_Adapter_Pdo_Mysql extends Zend_Db_Adapter_Pdo_Mysql implements V if (isset($condition['to'])) { $query .= empty($query) ? '' : ' AND '; $to = $this->_prepareSqlDateCondition($condition, 'to'); - $query = $this->_prepareQuotedSqlCondition($query . $conditionKeyMap['to'], $to, $fieldName); + $query = $query . $this->_prepareQuotedSqlCondition($conditionKeyMap['to'], $to, $fieldName); } } elseif (array_key_exists($key, $conditionKeyMap)) { $value = $condition[$key]; diff --git lib/Varien/Filter/Template.php lib/Varien/Filter/Template.php index bca16197ed1..249f87f36f9 100644 --- lib/Varien/Filter/Template.php +++ lib/Varien/Filter/Template.php @@ -234,6 +234,8 @@ class Varien_Filter_Template implements Zend_Filter_Interface $stackVars = $tokenizer->tokenize(); $result = $default; $last = 0; + /** @var $emailPathValidator Mage_Adminhtml_Model_Email_PathValidator */ + $emailPathValidator = $this->getEmailPathValidator(); for($i = 0; $i < count($stackVars); $i ++) { if ($i == 0 && isset($this->_templateVars[$stackVars[$i]['name']])) { // Getting of template value @@ -252,10 +254,16 @@ class Varien_Filter_Template implements Zend_Filter_Interface } } else if ($stackVars[$i]['type'] == 'method') { // Calling of object method - if (is_callable(array($stackVars[$i-1]['variable'], $stackVars[$i]['name'])) || substr($stackVars[$i]['name'],0,3) == 'get') { - $stackVars[$i]['variable'] = call_user_func_array(array($stackVars[$i-1]['variable'], - $stackVars[$i]['name']), - $stackVars[$i]['args']); + if (is_callable(array($stackVars[$i-1]['variable'], $stackVars[$i]['name'])) || substr($stackVars[$i]['name'],0,3) == 'get') + { + $isEncrypted = false; + if ($stackVars[$i]['name'] == 'getConfig') { + $isEncrypted = $emailPathValidator->isValid($stackVars[$i]['args']); + } + $stackVars[$i]['variable'] = call_user_func_array( + array($stackVars[$i-1]['variable'], $stackVars[$i]['name']), + !$isEncrypted ? $stackVars[$i]['args'] : array(null) + ); } } $last = $i; @@ -269,4 +277,14 @@ class Varien_Filter_Template implements Zend_Filter_Interface Varien_Profiler::stop("email_template_proccessing_variables"); return $result; } + + /** + * Retrieve model object + * + * @return Mage_Core_Model_Abstract + */ + protected function getEmailPathValidator() + { + return Mage::getModel('adminhtml/email_pathValidator'); + } }