#!/bin/bash # Patch apllying tool template # v0.1.2 # (c) Copyright 2013. Magento Inc. # # DO NOT CHANGE ANY LINE IN THIS FILE. # 1. Check required system tools _check_installed_tools() { local missed="" until [ -z "$1" ]; do type -t $1 >/dev/null 2>/dev/null if (( $? != 0 )); then missed="$missed $1" fi shift done echo $missed } REQUIRED_UTILS='sed patch' MISSED_REQUIRED_TOOLS=`_check_installed_tools $REQUIRED_UTILS` if (( `echo $MISSED_REQUIRED_TOOLS | wc -w` > 0 )); then echo -e "Error! Some required system tools, that are utilized in this sh script, are not installed:\nTool(s) \"$MISSED_REQUIRED_TOOLS\" is(are) missed, please install it(them)." exit 1 fi # 2. Determine bin path for system tools CAT_BIN=`which cat` PATCH_BIN=`which patch` SED_BIN=`which sed` PWD_BIN=`which pwd` BASENAME_BIN=`which basename` BASE_NAME=`$BASENAME_BIN "$0"` # 3. Help menu if [ "$1" = "-?" -o "$1" = "-h" -o "$1" = "--help" ] then $CAT_BIN << EOFH Usage: sh $BASE_NAME [--help] [-R|--revert] [--list] Apply embedded patch. -R, --revert Revert previously applied embedded patch --list Show list of applied patches --help Show this help message EOFH exit 0 fi # 4. Get "revert" flag and "list applied patches" flag REVERT_FLAG= SHOW_APPLIED_LIST=0 if [ "$1" = "-R" -o "$1" = "--revert" ] then REVERT_FLAG=-R fi if [ "$1" = "--list" ] then SHOW_APPLIED_LIST=1 fi # 5. File pathes CURRENT_DIR=`$PWD_BIN`/ APP_ETC_DIR=`echo "$CURRENT_DIR""app/etc/"` APPLIED_PATCHES_LIST_FILE=`echo "$APP_ETC_DIR""applied.patches.list"` # 6. Show applied patches list if requested if [ "$SHOW_APPLIED_LIST" -eq 1 ] ; then echo -e "Applied/reverted patches list:" if [ -e "$APPLIED_PATCHES_LIST_FILE" ] then if [ ! -r "$APPLIED_PATCHES_LIST_FILE" ] then echo "ERROR: \"$APPLIED_PATCHES_LIST_FILE\" must be readable so applied patches list can be shown." exit 1 else $SED_BIN -n "/SUP-\|SUPEE-/p" $APPLIED_PATCHES_LIST_FILE fi else echo "" fi exit 0 fi # 7. Check applied patches track file and its directory _check_files() { if [ ! -e "$APP_ETC_DIR" ] then echo "ERROR: \"$APP_ETC_DIR\" must exist for proper tool work." exit 1 fi if [ ! -w "$APP_ETC_DIR" ] then echo "ERROR: \"$APP_ETC_DIR\" must be writeable for proper tool work." exit 1 fi if [ -e "$APPLIED_PATCHES_LIST_FILE" ] then if [ ! -w "$APPLIED_PATCHES_LIST_FILE" ] then echo "ERROR: \"$APPLIED_PATCHES_LIST_FILE\" must be writeable for proper tool work." exit 1 fi fi } _check_files # 8. Apply/revert patch # Note: there is no need to check files permissions for files to be patched. # "patch" tool will not modify any file if there is not enough permissions for all files to be modified. # Get start points for additional information and patch data SKIP_LINES=$((`$SED_BIN -n "/^__PATCHFILE_FOLLOWS__$/=" "$CURRENT_DIR""$BASE_NAME"` + 1)) ADDITIONAL_INFO_LINE=$(($SKIP_LINES - 3))p _apply_revert_patch() { DRY_RUN_FLAG= if [ "$1" = "dry-run" ] then DRY_RUN_FLAG=" --dry-run" echo "Checking if patch can be applied/reverted successfully..." fi PATCH_APPLY_REVERT_RESULT=`$SED_BIN -e '1,/^__PATCHFILE_FOLLOWS__$/d' "$CURRENT_DIR""$BASE_NAME" | $PATCH_BIN $DRY_RUN_FLAG $REVERT_FLAG -p0` PATCH_APPLY_REVERT_STATUS=$? if [ $PATCH_APPLY_REVERT_STATUS -eq 1 ] ; then echo -e "ERROR: Patch can't be applied/reverted successfully.\n\n$PATCH_APPLY_REVERT_RESULT" exit 1 fi if [ $PATCH_APPLY_REVERT_STATUS -eq 2 ] ; then echo -e "ERROR: Patch can't be applied/reverted successfully." exit 2 fi } REVERTED_PATCH_MARK= if [ -n "$REVERT_FLAG" ] then REVERTED_PATCH_MARK=" | REVERTED" fi _apply_revert_patch dry-run _apply_revert_patch # 9. Track patch applying result echo "Patch was applied/reverted successfully." ADDITIONAL_INFO=`$SED_BIN -n ""$ADDITIONAL_INFO_LINE"" "$CURRENT_DIR""$BASE_NAME"` APPLIED_REVERTED_ON_DATE=`date -u +"%F %T UTC"` APPLIED_REVERTED_PATCH_INFO=`echo -n "$APPLIED_REVERTED_ON_DATE"" | ""$ADDITIONAL_INFO""$REVERTED_PATCH_MARK"` echo -e "$APPLIED_REVERTED_PATCH_INFO\n$PATCH_APPLY_REVERT_RESULT\n\n" >> "$APPLIED_PATCHES_LIST_FILE" exit 0 SUPEE-10570_CE_v1.9.3.7 | CE_1.9.3.7 | v1 | 418f82905c75afc286ae12fd70869429cf16aa37 | Fri Mar 16 13:12:38 2018 +0200 | ce-1.9.3.7-dev __PATCHFILE_FOLLOWS__ diff --git app/Mage.php app/Mage.php index d66756b..949f47d 100644 --- app/Mage.php +++ app/Mage.php @@ -844,6 +844,7 @@ final class Mage $message = print_r($message, true); } + $message = addcslashes($message, 'log($message, $level); } catch (Exception $e) { diff --git app/code/core/Mage/Admin/Helper/Block.php app/code/core/Mage/Admin/Helper/Block.php index 4e09ab3..d0ee857 100644 --- app/code/core/Mage/Admin/Helper/Block.php +++ app/code/core/Mage/Admin/Helper/Block.php @@ -56,4 +56,14 @@ class Mage_Admin_Helper_Block { return isset($this->_allowedTypes[$type]); } + + /** + * Get disallowed names for block + * + * @return bool + */ + public function getDisallowedBlockNames() + { + return Mage::getResourceModel('admin/block')->getDisallowedBlockNames(); + } } diff --git app/code/core/Mage/Admin/Model/Block.php app/code/core/Mage/Admin/Model/Block.php index d6768b8..f5c5d28 100644 --- app/code/core/Mage/Admin/Model/Block.php +++ app/code/core/Mage/Admin/Model/Block.php @@ -53,6 +53,10 @@ class Mage_Admin_Model_Block extends Mage_Core_Model_Abstract if (!Zend_Validate::is($this->getBlockName(), 'NotEmpty')) { $errors[] = Mage::helper('adminhtml')->__('Block Name is required field.'); } + $disallowedBlockNames = Mage::helper('admin/block')->getDisallowedBlockNames(); + if (in_array($this->getBlockName(), $disallowedBlockNames)) { + $errors[] = Mage::helper('adminhtml')->__('Block Name is disallowed.'); + } if (!Zend_Validate::is($this->getBlockName(), 'Regex', array('/^[-_a-zA-Z0-9\/]*$/'))) { $errors[] = Mage::helper('adminhtml')->__('Block Name is incorrect.'); } diff --git app/code/core/Mage/Admin/Model/Resource/Block.php app/code/core/Mage/Admin/Model/Resource/Block.php index dccc979..084a820 100644 --- app/code/core/Mage/Admin/Model/Resource/Block.php +++ app/code/core/Mage/Admin/Model/Resource/Block.php @@ -39,6 +39,13 @@ class Mage_Admin_Model_Resource_Block extends Mage_Core_Model_Resource_Db_Abstra const CACHE_ID = 'permission_block'; /** + * Disallowed names for block + * + * @var array + */ + protected $disallowedBlockNames = array('install/end'); + + /** * Define main table * */ @@ -70,6 +77,10 @@ class Mage_Admin_Model_Resource_Block extends Mage_Core_Model_Resource_Db_Abstra /** @var Mage_Admin_Model_Resource_Block_Collection $collection */ $collection = Mage::getResourceModel('admin/block_collection'); $collection->addFieldToFilter('is_allowed', array('eq' => 1)); + $disallowedBlockNames = $this->getDisallowedBlockNames(); + if (is_array($disallowedBlockNames) && count($disallowedBlockNames) > 0) { + $collection->addFieldToFilter('block_name', array('nin' => $disallowedBlockNames)); + } $data = $collection->getColumnValues('block_name'); $data = array_flip($data); Mage::app()->saveCache( @@ -98,4 +109,14 @@ class Mage_Admin_Model_Resource_Block extends Mage_Core_Model_Resource_Db_Abstra $this->_generateCache(); return parent::_afterDelete($object); } + + /** + * Get disallowed names for block + * + * @return array + */ + public function getDisallowedBlockNames() + { + return $this->disallowedBlockNames; + } } diff --git app/code/core/Mage/Admin/Model/User.php app/code/core/Mage/Admin/Model/User.php index 0da4d48..57d04de 100644 --- app/code/core/Mage/Admin/Model/User.php +++ app/code/core/Mage/Admin/Model/User.php @@ -379,7 +379,7 @@ class Mage_Admin_Model_User extends Mage_Core_Model_Abstract /** * Login user * - * @param string $login + * @param string $username * @param string $password * @return Mage_Admin_Model_User */ @@ -387,6 +387,7 @@ class Mage_Admin_Model_User extends Mage_Core_Model_Abstract { if ($this->authenticate($username, $password)) { $this->getResource()->recordLogin($this); + Mage::getSingleton('core/session')->renewFormKey(); } return $this; } diff --git app/code/core/Mage/Adminhtml/Block/Catalog/Product/Grid.php app/code/core/Mage/Adminhtml/Block/Catalog/Product/Grid.php index 3b065c6..7cbbd50 100644 --- app/code/core/Mage/Adminhtml/Block/Catalog/Product/Grid.php +++ app/code/core/Mage/Adminhtml/Block/Catalog/Product/Grid.php @@ -161,7 +161,7 @@ class Mage_Adminhtml_Block_Catalog_Product_Grid extends Mage_Adminhtml_Block_Wid if ($store->getId()) { $this->addColumn('custom_name', array( - 'header'=> Mage::helper('catalog')->__('Name in %s', $store->getName()), + 'header'=> Mage::helper('catalog')->__('Name in %s', $this->escapeHtml($store->getName())), 'index' => 'custom_name', )); } diff --git app/code/core/Mage/Adminhtml/Block/Newsletter/Template/Grid/Renderer/Sender.php app/code/core/Mage/Adminhtml/Block/Newsletter/Template/Grid/Renderer/Sender.php index f64c063..4116c2a 100644 --- app/code/core/Mage/Adminhtml/Block/Newsletter/Template/Grid/Renderer/Sender.php +++ app/code/core/Mage/Adminhtml/Block/Newsletter/Template/Grid/Renderer/Sender.php @@ -38,10 +38,10 @@ class Mage_Adminhtml_Block_Newsletter_Template_Grid_Renderer_Sender extends Mage { $str = ''; if($row->getTemplateSenderName()) { - $str .= htmlspecialchars($row->getTemplateSenderName()) . ' '; + $str .= $this->escapeHtml($row->getTemplateSenderName()) . ' '; } if($row->getTemplateSenderEmail()) { - $str .= '[' . $row->getTemplateSenderEmail() . ']'; + $str .= '[' .$this->escapeHtml($row->getTemplateSenderEmail()) . ']'; } if($str == '') { $str .= '---'; diff --git app/code/core/Mage/Adminhtml/Block/Sales/Order/Grid.php app/code/core/Mage/Adminhtml/Block/Sales/Order/Grid.php index 5a12b55..1d6d4d6 100644 --- app/code/core/Mage/Adminhtml/Block/Sales/Order/Grid.php +++ app/code/core/Mage/Adminhtml/Block/Sales/Order/Grid.php @@ -78,6 +78,7 @@ class Mage_Adminhtml_Block_Sales_Order_Grid extends Mage_Adminhtml_Block_Widget_ 'type' => 'store', 'store_view'=> true, 'display_deleted' => true, + 'escape' => true, )); } diff --git app/code/core/Mage/Adminhtml/Block/Sales/Order/View/Info.php app/code/core/Mage/Adminhtml/Block/Sales/Order/View/Info.php index ba1ccf9..60131bf 100644 --- app/code/core/Mage/Adminhtml/Block/Sales/Order/View/Info.php +++ app/code/core/Mage/Adminhtml/Block/Sales/Order/View/Info.php @@ -64,7 +64,7 @@ class Mage_Adminhtml_Block_Sales_Order_View_Info extends Mage_Adminhtml_Block_Sa $store->getGroup()->getName(), $store->getName() ); - return implode('
', $name); + return implode('
', array_map(array($this, 'escapeHtml'), $name)); } return null; } diff --git app/code/core/Mage/Adminhtml/Block/System/Store/Edit/Form.php app/code/core/Mage/Adminhtml/Block/System/Store/Edit/Form.php index 64bff6b..aad8429 100644 --- app/code/core/Mage/Adminhtml/Block/System/Store/Edit/Form.php +++ app/code/core/Mage/Adminhtml/Block/System/Store/Edit/Form.php @@ -245,7 +245,7 @@ class Mage_Adminhtml_Block_System_Store_Edit_Form extends Mage_Adminhtml_Block_W $values[] = array('label'=>$group->getName(),'value'=>$group->getId()); } } - $groups[] = array('label'=>$website->getName(),'value'=>$values); + $groups[] = array('label' => $this->escapeHtml($website->getName()), 'value' => $values); } $fieldset->addField('store_group_id', 'select', array( 'name' => 'store[group_id]', diff --git app/code/core/Mage/Adminhtml/Block/Tag/Assigned/Grid.php app/code/core/Mage/Adminhtml/Block/Tag/Assigned/Grid.php index c6854dc..8abecc1 100644 --- app/code/core/Mage/Adminhtml/Block/Tag/Assigned/Grid.php +++ app/code/core/Mage/Adminhtml/Block/Tag/Assigned/Grid.php @@ -174,7 +174,7 @@ class Mage_Adminhtml_Block_Tag_Assigned_Grid extends Mage_Adminhtml_Block_Widget if ($store->getId()) { $this->addColumn('custom_name', array( - 'header'=> Mage::helper('catalog')->__('Name in %s', $store->getName()), + 'header'=> Mage::helper('catalog')->__('Name in %s', $this->escapeHtml($store->getName())), 'index' => 'custom_name', )); } diff --git app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Renderer/Store.php app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Renderer/Store.php index 9806072..e5ac4a0 100644 --- app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Renderer/Store.php +++ app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Renderer/Store.php @@ -111,11 +111,11 @@ class Mage_Adminhtml_Block_Widget_Grid_Column_Renderer_Store $data = $this->_getStoreModel()->getStoresStructure(false, $origStores); foreach ($data as $website) { - $out .= $website['label'] . '
'; + $out .= Mage::helper('core')->escapeHtml($website['label']) . '
'; foreach ($website['children'] as $group) { - $out .= str_repeat(' ', 3) . $group['label'] . '
'; + $out .= str_repeat(' ', 3) . Mage::helper('core')->escapeHtml($group['label']) . '
'; foreach ($group['children'] as $store) { - $out .= str_repeat(' ', 6) . $store['label'] . '
'; + $out .= str_repeat(' ', 6) . Mage::helper('core')->escapeHtml($store['label']) . '
'; } } } diff --git app/code/core/Mage/Adminhtml/Block/Widget/Tabs.php app/code/core/Mage/Adminhtml/Block/Widget/Tabs.php index 0bd366b..8471f0a 100644 --- app/code/core/Mage/Adminhtml/Block/Widget/Tabs.php +++ app/code/core/Mage/Adminhtml/Block/Widget/Tabs.php @@ -289,9 +289,9 @@ class Mage_Adminhtml_Block_Widget_Tabs extends Mage_Adminhtml_Block_Widget public function getTabLabel($tab) { if ($tab instanceof Mage_Adminhtml_Block_Widget_Tab_Interface) { - return $tab->getTabLabel(); + return $this->escapeHtml($tab->getTabLabel()); } - return $tab->getLabel(); + return $this->escapeHtml($tab->getLabel()); } public function getTabContent($tab) diff --git app/code/core/Mage/Adminhtml/Model/Config/Data.php app/code/core/Mage/Adminhtml/Model/Config/Data.php index 0f35790..dbbe27a 100644 --- app/code/core/Mage/Adminhtml/Model/Config/Data.php +++ app/code/core/Mage/Adminhtml/Model/Config/Data.php @@ -117,6 +117,7 @@ class Mage_Adminhtml_Model_Config_Data extends Varien_Object } foreach ($groupData['fields'] as $field => $fieldData) { + $field = ltrim($field, '/'); $fieldConfig = $sections->descend($section . '/groups/' . $group . '/fields/' . $field); if (!$fieldConfig && $clonedFields && isset($mappedFields[$field])) { $fieldConfig = $sections->descend($section . '/groups/' . $group . '/fields/' diff --git app/code/core/Mage/Adminhtml/Model/System/Store.php app/code/core/Mage/Adminhtml/Model/System/Store.php index afad880..32caa42 100644 --- app/code/core/Mage/Adminhtml/Model/System/Store.php +++ app/code/core/Mage/Adminhtml/Model/System/Store.php @@ -151,7 +151,7 @@ class Mage_Adminhtml_Model_System_Store extends Varien_Object } if (!$websiteShow) { $options[] = array( - 'label' => $website->getName(), + 'label' => Mage::helper('core')->escapeHtml($website->getName()), 'value' => array() ); $websiteShow = true; @@ -161,13 +161,15 @@ class Mage_Adminhtml_Model_System_Store extends Varien_Object $values = array(); } $values[] = array( - 'label' => str_repeat($nonEscapableNbspChar, 4) . $store->getName(), + 'label' => str_repeat($nonEscapableNbspChar, 4) . + Mage::helper('core')->escapeHtml($store->getName()), 'value' => $store->getId() ); } if ($groupShow) { $options[] = array( - 'label' => str_repeat($nonEscapableNbspChar, 4) . $group->getName(), + 'label' => str_repeat($nonEscapableNbspChar, 4) . + Mage::helper('core')->escapeHtml($group->getName()), 'value' => $values ); } diff --git app/code/core/Mage/Adminhtml/controllers/Catalog/ProductController.php app/code/core/Mage/Adminhtml/controllers/Catalog/ProductController.php index 351e6be..41b5255 100644 --- app/code/core/Mage/Adminhtml/controllers/Catalog/ProductController.php +++ app/code/core/Mage/Adminhtml/controllers/Catalog/ProductController.php @@ -723,6 +723,16 @@ class Mage_Adminhtml_Catalog_ProductController extends Mage_Adminhtml_Controller $this->_filterStockData($data['product']['stock_data']); $product = $this->_initProductSave(); + // check sku attribute + $productSku = $product->getSku(); + if ($productSku && $productSku != Mage::helper('core')->stripTags($productSku)) { + $this->_getSession()->addError($this->__('HTML tags are not allowed in SKU attribute.')); + $this->_redirect('*/*/edit', array( + 'id' => $productId, + '_current' => true + )); + return; + } try { $product->save(); diff --git app/code/core/Mage/Adminhtml/controllers/System/BackupController.php app/code/core/Mage/Adminhtml/controllers/System/BackupController.php index 1b7916b..dd90f7e 100644 --- app/code/core/Mage/Adminhtml/controllers/System/BackupController.php +++ app/code/core/Mage/Adminhtml/controllers/System/BackupController.php @@ -34,6 +34,17 @@ class Mage_Adminhtml_System_BackupController extends Mage_Adminhtml_Controller_Action { /** + * Controller predispatch method + * + * @return Mage_Adminhtml_Controller_Action + */ + public function preDispatch() + { + $this->_setForcedFormKeyActions('create'); + return parent::preDispatch(); + } + + /** * Backup list action */ public function indexAction() diff --git app/code/core/Mage/Core/Model/Variable.php app/code/core/Mage/Core/Model/Variable.php index 8f4baf8..87e1dac 100644 --- app/code/core/Mage/Core/Model/Variable.php +++ app/code/core/Mage/Core/Model/Variable.php @@ -141,7 +141,10 @@ class Mage_Core_Model_Variable extends Mage_Core_Model_Abstract foreach ($collection->toOptionArray() as $variable) { $variables[] = array( 'value' => '{{customVar code=' . $variable['value'] . '}}', - 'label' => Mage::helper('core')->__('%s', $variable['label']) + 'label' => Mage::helper('core')->__( + '%s', + Mage::helper('core')->escapeHtml($variable['label'] + )) ); } if ($withGroup && $variables) { diff --git app/code/core/Mage/Customer/etc/config.xml app/code/core/Mage/Customer/etc/config.xml index b87cf72..54aaba1 100644 --- app/code/core/Mage/Customer/etc/config.xml +++ app/code/core/Mage/Customer/etc/config.xml @@ -28,7 +28,7 @@ - 1.6.2.0.5 + 1.6.2.0.5.1.2 diff --git app/code/core/Mage/Customer/sql/customer_setup/upgrade-1.6.2.0.5.1.1-1.6.2.0.5.1.2.php app/code/core/Mage/Customer/sql/customer_setup/upgrade-1.6.2.0.5.1.1-1.6.2.0.5.1.2.php new file mode 100644 index 0000000..543bc81 --- /dev/null +++ app/code/core/Mage/Customer/sql/customer_setup/upgrade-1.6.2.0.5.1.1-1.6.2.0.5.1.2.php @@ -0,0 +1,38 @@ +startSetup(); + +$installer->addAttribute('customer', 'password_created_at', array( + 'label' => 'Password created at', + 'visible' => false, + 'required' => false, + 'type' => 'int' +)); + +$installer->endSetup(); diff --git app/code/core/Mage/Downloadable/etc/config.xml app/code/core/Mage/Downloadable/etc/config.xml index f61934c..b509365 100644 --- app/code/core/Mage/Downloadable/etc/config.xml +++ app/code/core/Mage/Downloadable/etc/config.xml @@ -28,7 +28,7 @@ - 1.6.0.0.2 + 1.6.0.0.2.1.2 @@ -389,7 +389,7 @@ Samples Links 1 - inline + attachment 1 diff --git app/code/core/Mage/Downloadable/etc/system.xml app/code/core/Mage/Downloadable/etc/system.xml index c929d9c..e67eae8 100644 --- app/code/core/Mage/Downloadable/etc/system.xml +++ app/code/core/Mage/Downloadable/etc/system.xml @@ -96,6 +96,7 @@ 1 1 1 + Using inline option could potentially lead to security issues. diff --git app/code/core/Mage/Downloadable/sql/downloadable_setup/upgrade-1.6.0.0.2.1.1-1.6.0.0.2.1.2.php app/code/core/Mage/Downloadable/sql/downloadable_setup/upgrade-1.6.0.0.2.1.1-1.6.0.0.2.1.2.php new file mode 100644 index 0000000..b2ac9a6 --- /dev/null +++ app/code/core/Mage/Downloadable/sql/downloadable_setup/upgrade-1.6.0.0.2.1.1-1.6.0.0.2.1.2.php @@ -0,0 +1,37 @@ +startSetup(); +$connection = $installer->getConnection(); +$connection->delete( + $this->getTable('core_config_data'), + $connection->prepareSqlCondition('path', array( + 'like' => 'catalog/downloadable/content_disposition' + )) +); +$installer->endSetup(); diff --git app/code/core/Mage/ImportExport/Model/Import.php app/code/core/Mage/ImportExport/Model/Import.php index 534d407..b1448b0 100644 --- app/code/core/Mage/ImportExport/Model/Import.php +++ app/code/core/Mage/ImportExport/Model/Import.php @@ -398,6 +398,10 @@ class Mage_ImportExport_Model_Import extends Mage_ImportExport_Model_Abstract public function uploadSource() { $entity = $this->getEntity(); + $validTypes = array_keys(Mage_ImportExport_Model_Config::getModels(self::CONFIG_KEY_ENTITIES)); + if (!in_array($entity, $validTypes)) { + Mage::throwException(Mage::helper('importexport')->__('Incorrect entity type')); + } $uploader = Mage::getModel('core/file_uploader', self::FIELD_NAME_SOURCE_FILE); $uploader->skipDbProcessing(true); $result = $uploader->save(self::getWorkingDir()); diff --git app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php index b3d8a92..0dfb3a6 100644 --- app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php +++ app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php @@ -227,6 +227,11 @@ class Mage_ImportExport_Model_Import_Entity_Product extends Mage_ImportExport_Mo * Error - super products sku not found */ const ERROR_SUPER_PRODUCTS_SKU_NOT_FOUND = 'superProductsSkuNotFound'; + + /** + * Error - invalid product sku + */ + const ERROR_INVALID_PRODUCT_SKU = 'invalidSku'; /**#@-*/ /** @@ -315,7 +320,8 @@ class Mage_ImportExport_Model_Import_Entity_Product extends Mage_ImportExport_Mo self::ERROR_INVALID_TIER_PRICE_GROUP => 'Tier Price customer group ID is invalid', self::ERROR_TIER_DATA_INCOMPLETE => 'Tier Price data is incomplete', self::ERROR_SKU_NOT_FOUND_FOR_DELETE => 'Product with specified SKU not found', - self::ERROR_SUPER_PRODUCTS_SKU_NOT_FOUND => 'Product with specified super products SKU not found' + self::ERROR_SUPER_PRODUCTS_SKU_NOT_FOUND => 'Product with specified super products SKU not found', + self::ERROR_INVALID_PRODUCT_SKU => 'Invalid value in SKU column. HTML tags are not allowed' ); /** @@ -797,6 +803,22 @@ class Mage_ImportExport_Model_Import_Entity_Product extends Mage_ImportExport_Mo } /** + * Check product sku data. + * + * @param array $rowData + * @param int $rowNum + * @return bool + */ + protected function _isProductSkuValid(array $rowData, $rowNum) + { + if (isset($rowData['sku']) && $rowData['sku'] != Mage::helper('core')->stripTags($rowData['sku'])) { + $this->addRowError(self::ERROR_INVALID_PRODUCT_SKU, $rowNum); + return false; + } + return true; + } + + /** * Custom options save. * * @return Mage_ImportExport_Model_Import_Entity_Product @@ -2160,6 +2182,7 @@ class Mage_ImportExport_Model_Import_Entity_Product extends Mage_ImportExport_Mo $this->_isTierPriceValid($rowData, $rowNum); $this->_isGroupPriceValid($rowData, $rowNum); $this->_isSuperProductsSkuValid($rowData, $rowNum); + $this->_isProductSkuValid($rowData, $rowNum); } /** diff --git app/code/core/Mage/Shipping/Model/Info.php app/code/core/Mage/Shipping/Model/Info.php index f6b425a..5373555 100644 --- app/code/core/Mage/Shipping/Model/Info.php +++ app/code/core/Mage/Shipping/Model/Info.php @@ -79,7 +79,7 @@ class Mage_Shipping_Model_Info extends Varien_Object { $order = Mage::getModel('sales/order')->load($this->getOrderId()); - if (!$order->getId() || $this->getProtectCode() != $order->getProtectCode()) { + if (!$order->getId() || $this->getProtectCode() !== $order->getProtectCode()) { return false; } @@ -96,7 +96,7 @@ class Mage_Shipping_Model_Info extends Varien_Object /* @var $model Mage_Sales_Model_Order_Shipment */ $model = Mage::getModel('sales/order_shipment'); $ship = $model->load($this->getShipId()); - if (!$ship->getEntityId() || $this->getProtectCode() != $ship->getProtectCode()) { + if (!$ship->getEntityId() || $this->getProtectCode() !== $ship->getProtectCode()) { return false; } @@ -161,7 +161,7 @@ class Mage_Shipping_Model_Info extends Varien_Object public function getTrackingInfoByTrackId() { $track = Mage::getModel('sales/order_shipment_track')->load($this->getTrackId()); - if ($track->getId() && $this->getProtectCode() == $track->getProtectCode()) { + if ($track->getId() && $this->getProtectCode() === $track->getProtectCode()) { $this->_trackingInfo = array(array($track->getNumberDetail())); } return $this->_trackingInfo; diff --git app/code/core/Mage/Widget/controllers/Adminhtml/Widget/InstanceController.php app/code/core/Mage/Widget/controllers/Adminhtml/Widget/InstanceController.php index b10376e..f7e8004 100644 --- app/code/core/Mage/Widget/controllers/Adminhtml/Widget/InstanceController.php +++ app/code/core/Mage/Widget/controllers/Adminhtml/Widget/InstanceController.php @@ -175,7 +175,7 @@ class Mage_Widget_Adminhtml_Widget_InstanceController extends Mage_Adminhtml_Con ->setStoreIds($this->getRequest()->getPost('store_ids', array(0))) ->setSortOrder($this->getRequest()->getPost('sort_order', 0)) ->setPageGroups($this->getRequest()->getPost('widget_instance')) - ->setWidgetParameters($this->getRequest()->getPost('parameters')); + ->setWidgetParameters($this->_prepareParameters()); try { $widgetInstance->save(); $this->_getSession()->addSuccess( @@ -304,4 +304,20 @@ class Mage_Widget_Adminhtml_Widget_InstanceController extends Mage_Adminhtml_Con { return Mage::getSingleton('admin/session')->isAllowed('cms/widget_instance'); } + + /** + * Prepare widget parameters + * + * @return array + */ + protected function _prepareParameters() { + $result = array(); + $parameters = $this->getRequest()->getPost('parameters'); + if(is_array($parameters) && count($parameters)) { + foreach ($parameters as $key => $value) { + $result[Mage::helper('core')->stripTags($key)] = $value; + } + } + return $result; + } } diff --git app/code/core/Mage/XmlConnect/Block/Adminhtml/Connect/Dashboard/StoreSwitcher.php app/code/core/Mage/XmlConnect/Block/Adminhtml/Connect/Dashboard/StoreSwitcher.php index aae3bea..a2f6f5a 100644 --- app/code/core/Mage/XmlConnect/Block/Adminhtml/Connect/Dashboard/StoreSwitcher.php +++ app/code/core/Mage/XmlConnect/Block/Adminhtml/Connect/Dashboard/StoreSwitcher.php @@ -74,7 +74,7 @@ class Mage_XmlConnect_Block_Adminhtml_Connect_Dashboard_StoreSwitcher extends Ma if ($this->hasDefaultOption()) { $this->_addSwitcherItem($switcherItemsXmlObj, Mage_XmlConnect_Helper_AdminApplication::ALL_STORE_VIEWS, - array('label' => $this->getDefaultStoreName(), 'level' => 1)); + array('label' => $this->escapeHtml($this->getDefaultStoreName()), 'level' => 1)); } foreach ($websites as $website) { @@ -101,14 +101,14 @@ class Mage_XmlConnect_Block_Adminhtml_Connect_Dashboard_StoreSwitcher extends Ma if ($showWebsite == false) { $showWebsite = true; $this->_addSwitcherItem($switcherItemsXmlObj, null, array( - 'label' => $website->getName(), 'level' => 1 + 'label' => $this->escapeHtml($website->getName()), 'level' => 1 ), true); } if ($showGroup == false) { $showGroup = true; $this->_addSwitcherItem($switcherItemsXmlObj, null, array( - 'label' => $group->getName(), 'level' => 2 + 'label' => $this->escapeHtml($group->getName()), 'level' => 2 ), true); } @@ -117,7 +117,7 @@ class Mage_XmlConnect_Block_Adminhtml_Connect_Dashboard_StoreSwitcher extends Ma } $this->_addSwitcherItem($switcherItemsXmlObj, $store->getId(), array( - 'label' => $store->getName(), 'level' => 3 + 'label' => $this->escapeHtml($store->getName()), 'level' => 3 )); } return $this; diff --git app/design/adminhtml/default/default/template/catalog/product/attribute/options.phtml app/design/adminhtml/default/default/template/catalog/product/attribute/options.phtml index cf15b8e..8a3b176 100644 --- app/design/adminhtml/default/default/template/catalog/product/attribute/options.phtml +++ app/design/adminhtml/default/default/template/catalog/product/attribute/options.phtml @@ -51,7 +51,7 @@ getStores() as $_store): ?> - + @@ -76,7 +76,7 @@
getName() ?>escapeHtml($_store->getName()); ?>
getStores() as $_store): ?> - + diff --git app/design/adminhtml/default/default/template/catalog/product/attribute/set/main.phtml app/design/adminhtml/default/default/template/catalog/product/attribute/set/main.phtml index d731dad..401fa70 100644 --- app/design/adminhtml/default/default/template/catalog/product/attribute/set/main.phtml +++ app/design/adminhtml/default/default/template/catalog/product/attribute/set/main.phtml @@ -115,6 +115,23 @@ cls:'folder' }); + this.ge.completeEdit = function(remainVisible) { + if (!this.editing) { + return; + } + this.editNode.attributes.input = this.getValue(); + this.setValue(this.getValue().escapeHTML()); + return Ext.tree.TreeEditor.prototype.completeEdit.call(this, remainVisible); + }; + + this.ge.triggerEdit = function(node) { + this.completeEdit(); + node.text = node.attributes.input; + node.attributes.text = node.attributes.input; + this.editNode = node; + this.startEdit(node.ui.textNode, node.text); + }; + this.root.addListener('beforeinsert', editSet.leftBeforeInsert); this.root.addListener('beforeappend', editSet.leftBeforeInsert); @@ -161,7 +178,7 @@ for( i in rootNode.childNodes ) { if(rootNode.childNodes[i].id) { var group = rootNode.childNodes[i]; - editSet.req.groups[gIterator] = new Array(group.id, group.attributes.text.strip(), (gIterator+1)); + editSet.req.groups[gIterator] = new Array(group.id, group.attributes.input.strip(), (gIterator+1)); var iterator = 0 for( j in group.childNodes ) { iterator ++; @@ -194,6 +211,8 @@ if (!config) return null; if (parent && config && config.length){ for (var i = 0; i < config.length; i++) { + config[i].input = config[i].text; + config[i].text = config[i].text.escapeHTML(); var node = new Ext.tree.TreeNode(config[i]); parent.appendChild(node); node.addListener('click', editSet.register); @@ -295,6 +314,7 @@ var newNode = new Ext.tree.TreeNode({ text : group_name.escapeHTML(), + input: group_name, cls : 'folder', allowDrop : true, allowDrag : true diff --git app/design/adminhtml/default/default/template/customer/tab/view.phtml app/design/adminhtml/default/default/template/customer/tab/view.phtml index 0ae9060..274e304 100644 --- app/design/adminhtml/default/default/template/customer/tab/view.phtml +++ app/design/adminhtml/default/default/template/customer/tab/view.phtml @@ -66,7 +66,7 @@ $createDateStore = $this->getStoreCreateDate(); - + diff --git app/design/adminhtml/default/default/template/customer/tab/view/sales.phtml app/design/adminhtml/default/default/template/customer/tab/view/sales.phtml index e2f460d..7ce5129 100644 --- app/design/adminhtml/default/default/template/customer/tab/view/sales.phtml +++ app/design/adminhtml/default/default/template/customer/tab/view/sales.phtml @@ -53,18 +53,18 @@ getStoreId() == 0): ?> - + > - + - + - + diff --git app/design/adminhtml/default/default/template/dashboard/store/switcher.phtml app/design/adminhtml/default/default/template/dashboard/store/switcher.phtml index 51aa26f..031e0fc 100644 --- app/design/adminhtml/default/default/template/dashboard/store/switcher.phtml +++ app/design/adminhtml/default/default/template/dashboard/store/switcher.phtml @@ -35,14 +35,14 @@ getStoreCollection($_group) as $_store): ?> - + - - + + - + diff --git app/design/adminhtml/default/default/template/downloadable/product/composite/fieldset/downloadable.phtml app/design/adminhtml/default/default/template/downloadable/product/composite/fieldset/downloadable.phtml index e6331bb..4505171 100644 --- app/design/adminhtml/default/default/template/downloadable/product/composite/fieldset/downloadable.phtml +++ app/design/adminhtml/default/default/template/downloadable/product/composite/fieldset/downloadable.phtml @@ -35,7 +35,7 @@
getLinks(); ?> getLinkSelectionRequired(); ?> -
>*' ?>getLinksTitle() ?>
+
>*' ?>escapeHtml($this->getLinksTitle()); ?>
getName() ?>escapeHtml($_store->getName()); ?> __('Position') ?> __('Is Default') ?>
__('Account Created in:') ?>getCreatedInStore() ?>escapeHtml($this->getCreatedInStore()); ?>
__('Customer Group:') ?> getStoreName() ?>escapeHtml($_row->getStoreName()); ?> getWebsiteName() ?>escapeHtml($_row->getWebsiteName()); ?> getGroupName() ?>escapeHtml($_row->getGroupName()); ?> getStoreName() ?>escapeHtml($_row->getStoreName()); ?> formatCurrency($_row->getLifetime(), $_row->getWebsiteId()) ?> formatCurrency($_row->getAvgsale(), $_row->getWebsiteId()) ?> - getStoreId() && $this->getUsedDefault())?'disabled="disabled"':'' ?> /> + getStoreId() && $this->getUsedDefault())?'disabled="disabled"':'' ?> /> isSingleStoreMode() ? Mage::helper('adminhtml')->__('[STORE VIEW]') : ''; ?> diff --git app/design/adminhtml/default/default/template/downloadable/sales/items/column/downloadable/creditmemo/name.phtml app/design/adminhtml/default/default/template/downloadable/sales/items/column/downloadable/creditmemo/name.phtml index cc50e4a..edfaadc 100644 --- app/design/adminhtml/default/default/template/downloadable/sales/items/column/downloadable/creditmemo/name.phtml +++ app/design/adminhtml/default/default/template/downloadable/sales/items/column/downloadable/creditmemo/name.phtml @@ -52,7 +52,7 @@ getLinks()): ?>
-
getLinksTitle(); ?>
+
escapeHtml($this->getLinksTitle()); ?>
getLinks()->getPurchasedItems() as $_link): ?>
escapeHtml($_link->getLinkTitle()); ?>
diff --git app/design/adminhtml/default/default/template/downloadable/sales/items/column/downloadable/invoice/name.phtml app/design/adminhtml/default/default/template/downloadable/sales/items/column/downloadable/invoice/name.phtml index ce3053c..6dfe1af 100644 --- app/design/adminhtml/default/default/template/downloadable/sales/items/column/downloadable/invoice/name.phtml +++ app/design/adminhtml/default/default/template/downloadable/sales/items/column/downloadable/invoice/name.phtml @@ -52,7 +52,7 @@ getLinks()): ?>
-
getLinksTitle(); ?>
+
escapeHtml($this->getLinksTitle()); ?>
getLinks()->getPurchasedItems() as $_link): ?>
escapeHtml($_link->getLinkTitle()); ?> (getNumberOfDownloadsBought()?$_link->getNumberOfDownloadsBought():Mage::helper('downloadable')->__('Unlimited') ?>)
diff --git app/design/adminhtml/default/default/template/downloadable/sales/items/column/downloadable/name.phtml app/design/adminhtml/default/default/template/downloadable/sales/items/column/downloadable/name.phtml index 90ccbca..03e117f 100644 --- app/design/adminhtml/default/default/template/downloadable/sales/items/column/downloadable/name.phtml +++ app/design/adminhtml/default/default/template/downloadable/sales/items/column/downloadable/name.phtml @@ -52,7 +52,7 @@ getLinks()): ?>
-
getLinksTitle(); ?>
+
escapeHtml($this->getLinksTitle()); ?>
getLinks()->getPurchasedItems() as $_link): ?>
escapeHtml($_link->getLinkTitle()) ?> (getNumberOfDownloadsUsed() . ' / ' . ($_link->getNumberOfDownloadsBought()?$_link->getNumberOfDownloadsBought():Mage::helper('downloadable')->__('U')) ?>)
diff --git app/design/adminhtml/default/default/template/eav/attribute/options.phtml app/design/adminhtml/default/default/template/eav/attribute/options.phtml index 30aa8c1..608aa4f 100644 --- app/design/adminhtml/default/default/template/eav/attribute/options.phtml +++ app/design/adminhtml/default/default/template/eav/attribute/options.phtml @@ -51,14 +51,14 @@ getStores() as $_store): ?> - + getLabelValues() ?> getStores() as $_store): ?> @@ -76,7 +76,7 @@
getName() ?>escapeHtml($_store->getName()); ?>
- getReadOnly()):?> disabled="disabled"/> + getReadOnly()):?> disabled="disabled"/>
getStores() as $_store): ?> - + diff --git app/design/adminhtml/default/default/template/newsletter/preview/store.phtml app/design/adminhtml/default/default/template/newsletter/preview/store.phtml index 53a2700..a665d18 100644 --- app/design/adminhtml/default/default/template/newsletter/preview/store.phtml +++ app/design/adminhtml/default/default/template/newsletter/preview/store.phtml @@ -35,13 +35,13 @@ getStores($group) as $store): ?> - + - + - + diff --git app/design/adminhtml/default/default/template/report/store/switcher.phtml app/design/adminhtml/default/default/template/report/store/switcher.phtml index b561f2f..2119819 100644 --- app/design/adminhtml/default/default/template/report/store/switcher.phtml +++ app/design/adminhtml/default/default/template/report/store/switcher.phtml @@ -40,14 +40,14 @@ getStoreCollection($_group) as $_store): ?> - + - - + + - + diff --git app/design/adminhtml/default/default/template/sales/order/view/info.phtml app/design/adminhtml/default/default/template/sales/order/view/info.phtml index 07e4403..7511468 100644 --- app/design/adminhtml/default/default/template/sales/order/view/info.phtml +++ app/design/adminhtml/default/default/template/sales/order/view/info.phtml @@ -63,7 +63,7 @@ $orderStoreDate = $this->formatDate($_order->getCreatedAtStoreDate(), 'medium', - + getRelationChildId()): ?> diff --git app/design/adminhtml/default/default/template/store/switcher.phtml app/design/adminhtml/default/default/template/store/switcher.phtml index f559794..3a1521a 100644 --- app/design/adminhtml/default/default/template/store/switcher.phtml +++ app/design/adminhtml/default/default/template/store/switcher.phtml @@ -29,7 +29,7 @@

- + getGroupCollection($_website) as $_group): ?> @@ -37,13 +37,13 @@ getStoreCollection($_group) as $_store): ?> - + - + - + diff --git app/design/adminhtml/default/default/template/system/convert/profile/wizard.phtml app/design/adminhtml/default/default/template/system/convert/profile/wizard.phtml index bd431ec..a8beaa8 100644 --- app/design/adminhtml/default/default/template/system/convert/profile/wizard.phtml +++ app/design/adminhtml/default/default/template/system/convert/profile/wizard.phtml @@ -203,9 +203,9 @@ Event.observe(window, 'load', function(){ - + - + diff --git app/design/adminhtml/default/default/template/tax/rate/title.phtml app/design/adminhtml/default/default/template/tax/rate/title.phtml index 1a09fc4..9ce2207 100644 --- app/design/adminhtml/default/default/template/tax/rate/title.phtml +++ app/design/adminhtml/default/default/template/tax/rate/title.phtml @@ -27,7 +27,7 @@ */ ?>

getStores() as $_store): ?> - + diff --git app/design/adminhtml/default/default/template/widget/form/renderer/fieldset.phtml app/design/adminhtml/default/default/template/widget/form/renderer/fieldset.phtml index 9333906..c2931cc 100644 --- app/design/adminhtml/default/default/template/widget/form/renderer/fieldset.phtml +++ app/design/adminhtml/default/default/template/widget/form/renderer/fieldset.phtml @@ -30,7 +30,7 @@ getLegend()): ?>
-

getLegend() ?>

+

escapeHtml($_element->getLegend()) ?>

getHeaderBar() ?>
diff --git app/locale/en_US/Mage_Catalog.csv app/locale/en_US/Mage_Catalog.csv index 3ae7af5..6521473 100644 --- app/locale/en_US/Mage_Catalog.csv +++ app/locale/en_US/Mage_Catalog.csv @@ -717,6 +717,7 @@ "The product has been deleted.","The product has been deleted." "The product has been duplicated.","The product has been duplicated." "The product has been saved.","The product has been saved." +"HTML tags are not allowed in SKU attribute.","HTML tags are not allowed in SKU attribute." "The product has required options","The product has required options" "The review has been deleted","The review has been deleted" "The review has been saved.","The review has been saved." diff --git app/locale/en_US/Mage_ImportExport.csv app/locale/en_US/Mage_ImportExport.csv index 52529cd..cc1470c 100644 --- app/locale/en_US/Mage_ImportExport.csv +++ app/locale/en_US/Mage_ImportExport.csv @@ -19,6 +19,7 @@ "Column names have duplicates","Column names have duplicates" "Column names is empty or is not an array","Column names is empty or is not an array" "Column names: ""%s"" are invalid","Column names: ""%s"" are invalid" +"Invalid value in SKU column. HTML tags are not allowed","Invalid value in SKU column. HTML tags are not allowed" "Customers","Customers" "Data is invalid or file is not uploaded","Data is invalid or file is not uploaded" "Delete Entities","Delete Entities" @@ -90,6 +91,7 @@ "Total size of uploadable files must not exceed %s","Total size of uploadable files must not exceed %s" "Unknown attribute filter type","Unknown attribute filter type" "Uploaded file has no extension","Uploaded file has no extension" +"Incorrect entity type","Incorrect entity type" "Validation finished successfully","Validation finished successfully" "in rows","in rows" "in rows:","in rows:" diff --git lib/Zend/Mail/Transport/Sendmail.php lib/Zend/Mail/Transport/Sendmail.php index 9323f58..96ae90f 100644 --- lib/Zend/Mail/Transport/Sendmail.php +++ lib/Zend/Mail/Transport/Sendmail.php @@ -119,8 +119,9 @@ class Zend_Mail_Transport_Sendmail extends Zend_Mail_Transport_Abstract ); } + $fromEmailHeader = str_replace(' ', '', $this->parameters); // Sanitize the From header - if (!Zend_Validate::is(str_replace(' ', '', $this->parameters), 'EmailAddress')) { + if (!Zend_Validate::is($fromEmailHeader, 'EmailAddress')) { throw new Zend_Mail_Transport_Exception('Potential code injection in From header'); } else { set_error_handler(array($this, '_handleMailErrors')); @@ -129,7 +130,7 @@ class Zend_Mail_Transport_Sendmail extends Zend_Mail_Transport_Abstract $this->_mail->getSubject(), $this->body, $this->header, - $this->parameters); + $fromEmailHeader); restore_error_handler(); } }
getName() ?>escapeHtml($_store->getName()); ?> __('Position') ?> __('Is Default') ?>
getOrderStoreName() ?>getOrderStoreName(); ?>
getName() ?>escapeHtml($_store->getName()); ?>