--- name: target-authoring description: "Canonical patterns for writing custom MSBuild targets. USE FOR: diagnosing and fixing custom target authoring anti-patterns; broken SDK target chains across files (e.g., Directory.Build.targets silently redefining SDK targets); targets that replace CompileDependsOn instead of extending it with $(CompileDependsOn); query targets returning stale results from Outputs vs Returns misuse; missing Inputs/Outputs causing unnecessary rebuilds; missing FileWrites registration. Covers DependsOnTargets vs BeforeTargets vs AfterTargets, the Build→CoreBuild three-level pattern, and the $(XxxDependsOn) chain-extension pattern. DO NOT USE FOR: incremental build tuning (use incremental-build), parallelization (use build-parallelism), general anti-patterns (use msbuild-antipatterns), non-MSBuild build systems." license: MIT --- # Custom Target Authoring Patterns Canonical patterns from `Microsoft.Common.CurrentVersion.targets` in the MSBuild repository. ## The Three-Level Target Chain Every major entry point (Build, Rebuild, Clean) delegates to a **property** listing its dependencies, which chains through Before → Core → After: ```xml BeforeBuild; CoreBuild; AfterBuild ``` `CoreBuild` delegates to `$(CoreBuildDependsOn)` and includes error handlers: ```xml ``` ### Rules - Delegate to a property (`DependsOnTargets="$(MyTargetDependsOn)"`), not hardcoded targets. - `OnError` goes inside the orchestrating target to ensure cleanup runs even on failure. - Empty Before/After targets are extensibility points. Users override them; SDKs never put logic in them. ## Chain Extension — Append, Never Overwrite When adding a custom target to an existing chain, **append** to the `DependsOn` property: ```xml $(CompileDependsOn);MyCodeGenTarget MyCodeGenTarget ``` ## DependsOnTargets vs BeforeTargets vs AfterTargets | Mechanism | Defined in | Best for | |---|---|---| | `DependsOnTargets` | The target that needs deps | Target explicitly requires others | | `BeforeTargets` | The injecting target | Insert before a target you don't own | | `AfterTargets` | The injecting target | Insert after a target you don't own | Validation targets use `BeforeTargets` to intercept all entry points: ```xml ``` **Rules:** - Use `DependsOnTargets` when your target needs specific prerequisites. - Use `BeforeTargets`/`AfterTargets` when injecting into a pipeline you don't own. - Prefer `BeforeTargets="CoreCompile"` over modifying `$(CompileDependsOn)` when you don't control the targets file. ## Returns vs Outputs ```xml ``` - **`Returns`** specifies what the MSBuild task receives when calling this project. Use for inter-project communication. - **`Outputs`** on inner targets is for incrementality (timestamp checks). Use for up-to-date detection. - Never mix the two purposes. Query targets (`GetTargetPath`, `GetTargetFrameworks`) should use `Returns`, not `Outputs`. ## Target Naming Conventions | Pattern | Meaning | Example | |---|---|---| | `_PrefixedName` | Internal/private target | `_TimeStampBeforeCompile` | | `CoreXxx` | The actual implementation | `CoreBuild`, `CoreCompile` | | `BeforeXxx` / `AfterXxx` | Empty extensibility hooks | `BeforeBuild`, `AfterCompile` | | `PrepareXxx` | Setup/validation phase | `PrepareForBuild` | | `ResolveXxx` | Discovery/resolution phase | `ResolveReferences` | | `GetXxx` | Lightweight query (no side effects) | `GetTargetPath` | ## Complete Custom Target Template ```xml _ValidateMyFeatureInputs; BeforeMyFeature; CoreMyFeature; AfterMyFeature ``` ## Common Pitfalls - **Overwriting `DependsOn` properties** drops SDK targets silently. Always include `$(ExistingProperty)` when appending. - **Using `Outputs` on query targets** causes MSBuild to skip them when "up to date," returning stale data. Use `Returns`. - **Defining targets in `.props`** means `BeforeTargets` on SDK targets have nothing to hook into yet. Move targets to `.targets`. - **Forgetting `OnError`** in orchestrating targets means file tracking fails on build errors, breaking subsequent incremental builds.