--- name: intelliconnect-service-style description: Create or update IntelliConnect Spring Boot service/serviceimpl code in this repository style. Use when adding backend services, service implementations, request DTOs, repository methods, CRUD methods, token-filtered get methods, SafetyService-bound permission boundaries, duplicate checks, dependency checks before delete, or Java compile verification for IntelliConnect. Also use when deciding whether a delete should fail on dependencies or cascade-delete related tables. --- # IntelliConnect Service Style Use this skill when implementing backend service/serviceimpl code in IntelliConnect. Prefer `PUT`/update flows that identify the target row by `id`. ## Workflow 1. Read existing nearby examples before editing: - `src/main/java/top/rslly/iot/services/agent/*ServiceImpl.java` - `src/main/java/top/rslly/iot/services/thingsModel/*ServiceImpl.java` - matching `dao/`, `models/`, and `param/request/` files. 2. Prefer the existing repository/service naming style over new abstractions. 3. Add or update the request DTO in `top.rslly.iot.param.request` when the service method accepts input from controller code. 4. Add derived Spring Data repository methods for simple lookups and pageable queries. 5. Use database-backed pagination for paged APIs; do not manually paginate non-empty lists in the service. 6. Use streams for simple collection projection, but avoid repeated repository calls and mutation-heavy stream code. 7. Keep controller permission checks outside mutating service methods when the repository pattern already uses `SafetyServiceImpl` wrappers. 8. Before implementing any delete path, inspect all related tables/repositories and decide whether the correct behavior is dependency failure or cascade delete. 9. If the dependency policy is not already obvious from nearby code, ask the user whether to return `HAS_DEPENDENCIES` or delete related records too. 10. Compile with JDK 21 after edits: ```powershell $env:JAVA_HOME='C:\Users\Lenovo\.jdks\ms-21.0.9'; $env:Path="$env:JAVA_HOME\bin;$env:Path"; .\mvnw.cmd -q -DskipTests compile ``` ## Service Interface Pattern Use interfaces under the same service package as the implementation. Common method shape: ```java List findAllById(int id); List findAllByProductId(int productId); JsonResult getThing(String token); JsonResult postThing(ThingParam param); JsonResult updateThing(ThingParam param); JsonResult deleteThing(int id); ``` Use `String token` for list getters that need user-specific filtering. Do not pass token into `post`, `update`, or `delete` when controller/SafetyService will authorize the operation before calling the service. ## Implementation Pattern Use `@Service`, `@Resource`, `@Transactional(rollbackFor = Exception.class)`, `JsonResult`, `ResultTool`, and `ResultCode` to match the repo. For `get... (String token)`, keep the whole role-based flow in one method, like other impls: ```java String tokenDeal = token.replace(JwtTokenUtil.TOKEN_PREFIX, ""); String role = JwtTokenUtil.getUserRole(tokenDeal); String username = JwtTokenUtil.getUsername(tokenDeal); List result; if (role.equals("ROLE_" + "wx_user")) { if (wxUserRepository.findAllByName(username).isEmpty()) { return ResultTool.fail(ResultCode.COMMON_FAIL); } // collect records through wx product binds } else if (!role.equals("[ROLE_admin]")) { if (userRepository.findAllByUsername(username).isEmpty()) { return ResultTool.fail(ResultCode.COMMON_FAIL); } // collect records through user product binds } else { result = repository.findAll(); } if (result.isEmpty()) { return ResultTool.fail(ResultCode.COMMON_FAIL); } else return ResultTool.success(result); ``` Do not split this into a helper unless the surrounding codebase already does so for the same type of service. Do not `return null`; return `ResultTool.fail(ResultCode.COMMON_FAIL)`. ## Collection Style Use streams for simple one-step projections from repository results, especially when extracting ids for scoped queries: ```java List productIdList = userProductBindRepository.findAllByUserId(userId) .stream() .map(UserProductBindEntity::getProductId) .toList(); ``` Prefer `.toList()` on Java 21 when the result is only passed to another method or returned. Use `new ArrayList<>(...)` or `collect(Collectors.toList())` only when later code must mutate the list. Do not use streams for code that needs side effects, complex branching, or repository calls per item. Prefer one repository query returning all needed rows, then a simple `map(...).toList()` if only a field is needed. Avoid duplicate repository calls. Store the result list once before checking it: ```java List wxUserEntityList = wxUserRepository.findAllByName(username); if (wxUserEntityList.isEmpty()) { return ResultTool.fail(ResultCode.COMMON_FAIL); } String appid = wxUserEntityList.getFirst().getAppid(); ``` ## Pagination Pattern For paged APIs, use Spring Data `Pageable`/`Page` and push pagination into the repository/database. Do not manually page non-empty data with `List.subList(...)`, stream `skip/limit`, loops, or in-memory sorting in the service. Controller methods should accept `pageNum` and `pageSize` with `@Min(1)` validation, then pass them to the service. Services should build `PageRequest.of(pageNum - 1, pageSize, Sort.by(...))` and call a repository method returning `Page`. Use derived repository methods for scoped paging, including permission-filtered ID lists: ```java Page findAllByIdIn(List ids, Pageable pageable); ``` If there are no authorized ids, returning `new PageImpl<>(List.of(), pageable, 0)` is acceptable. Do not use `PageImpl` to wrap a manually sliced non-empty result list when a repository query can page it. For permission-filtered pagination, first collect the authorized ids with simple stream projection, then pass the ids to a pageable repository method. If the id list is empty, return an empty page instead of querying with `IN ()`. ```java List productIdList = wxProductBindRepository.findAllByAppidAndOpenid(appid, openid) .stream() .map(WxProductBindEntity::getProductId) .toList(); Page result = productIdList.isEmpty() ? emptyProductPage(pageable) : productRepository.findAllByIdIn(productIdList, pageable); ``` ## Mutation Rules For `post`: - Validate required fields and referenced records such as `productId`. - If the controller already uses `@Valid`, do not duplicate DTO null/blank checks in the service. - Normalize strings with `trim()` before duplicate checks and saving. - Check duplicates before saving. - Return `ResultTool.fail(ResultCode.PARAM_NOT_VALID)` for missing/invalid parameters. - Return `ResultTool.fail(ResultCode.COMMON_FAIL)` for duplicate business records unless the local service uses a more specific result code. For `update`: - Prefer `id`-based updates for `PUT`: require `id`, load the existing entity first, and fail with `PARAM_NOT_VALID` when missing. - Do not design new `PUT` flows around natural keys unless the user explicitly asks for that exception. - Check duplicate conflicts while excluding the current `id`. - Update only intended fields and save the existing entity. For `delete`: - Load by id first; fail with `PARAM_NOT_VALID` when missing. - Check dependent records before deleting. - If related tables should block deletion, use `ResultCode.HAS_DEPENDENCIES`. - If related tables should be removed too, delete them in the same transaction before deleting the parent row. - When the dependency policy is unclear, ask the user before coding the delete path. - Return the repository delete result through `ResultTool.success(result)`. ## Duplicate Checks Use the business key the user specifies, including scope fields such as `productId`. Example for scoped uniqueness: ```java List duplicateList = repository.findAllByProductIdAndPairCodeAndAgentType(productId, pairCode, agentType); for (Entity duplicate : duplicateList) { if (!duplicate.getId().equals(param.getId())) { return ResultTool.fail(ResultCode.COMMON_FAIL); } } ``` When adding repository methods, prefer Spring Data derived names: ```java List findAllByProductIdAndPairCodeAndAgentType(Integer productId, String pairCode, String agentType); ``` ## Request DTO Pattern Use Lombok getters/setters or `@Data`, and Jakarta validation annotations already used in the repo. ```java @Getter @Setter public class ThingParam { private Integer id; @NotBlank(message = "name 不能为空") @Size(min = 1, max = 255, message = "name 长度必须在 1 到 255 之间") private String name; @NotNull(message = "productId 不能为空") private Integer productId; } ``` Use `Integer` for optional `id` and nullable request fields that need `@NotNull`. ## Safety Boundary If controller code will wrap calls with `SafetyServiceImpl`, keep service mutation methods focused on business invariants, not permission checks. Expected controller shape: ```java if (!safetyService.controlAuthorizeProduct(header, param.getProductId())) return ResultTool.fail(ResultCode.NO_PERMISSION); return thingService.postThing(param); ``` For delete/update by id, add a `SafetyServiceImpl` authorization helper only when controller integration is part of the task.