--- name: single-pass-review-completeness description: "Use when: making one review round complete instead of incremental, enumerating review dimensions up front, covering every file under each applicable dimension, declaring review coverage and uncovered dimensions, or preventing new findings on unchanged code in later review rounds." argument-hint: "The diff or change set to review, the change intent, and any dimensions the requester wants prioritized or excluded." --- # Single-Pass Review Completeness Structure one review round so it is complete by construction: enumerate the dimensions first, consider every file under each applicable dimension, and declare what was and was not covered. The failure mode this prevents is incremental review — new findings appearing in later rounds on code that did not change. **UTILITY SKILL.** INVOKES: repository inspection and non-destructive local checks. FOR SINGLE OPERATIONS: Review one locked diff and declare its coverage. ## When to Use Use when performing a review round that should be the only one, or when a review has been criticized for drip-feeding findings across rounds. Out of scope: deciding merge readiness after fixes, formatting individual findings, and re-reviewing fixes from an earlier round. ## DO NOT USE FOR: - Merge-readiness decisions, individual finding formatting, or verification of fixes from an earlier round. ## Required Inputs - The diff or change set. - The change intent. - Requester's dimension priorities or exclusions, when given. If the diff is unavailable, emit the BLOCK template. ## Dimension Catalogue (8) 1. Correctness — logic, edge cases, off-by-one, error paths. 2. Contracts — API, schema, config, wire-format compatibility. 3. Security — input handling, authn/authz, secrets, injection surfaces. 4. Concurrency and state — shared state, ordering, idempotency, lifecycle. 5. Performance — complexity, hot paths, resource usage, N+1 patterns. 6. Tests — coverage of changed behavior, test quality, missing negative paths. 7. Maintainability — naming, structure, duplication, comprehensibility. 8. Operability — logging, metrics, failure visibility, rollout/rollback. ## Procedure 1. Lock the diff under review; later pushes start a new pass, never extend this one. 2. List all eight dimensions and classify each as `swept`, `skipped`, or `n/a` before reporting findings, recording the reason in the coverage table's reason column. Use `n/a` when the diff has no surface for the dimension. Skipping is allowed only for requester exclusion or for missing expertise/context. 3. Consider every file under every applicable dimension. Choose file-by-file, dimension-by-dimension, or combined traversal according to the diff; traversal order does not replace coverage. Record findings tagged with their dimension. 4. After the sweep, do one anti-increment check: for each `swept` dimension, confirm every file in the diff was considered under it. List any file–dimension pair that was not as an explicit coverage gap, never silently. 5. Report with the declared-coverage output. ## Rules - Never report a dimension as `swept` if any file in the diff was not considered under it. - Findings outside the locked diff (pre-existing issues) are listed separately, not mixed into the pass findings. - A later round on the same locked diff may only contain findings traceable to declared coverage gaps or to new information; say so explicitly when invoked for such a round. ## Output Format ```markdown ## Single-Pass Review Report - Locked diff: - Change intent: ### Coverage declaration | Dimension | Status | Reason if not swept | |-----------|--------|---------------------| | | | | One row per dimension, all eight dimensions. ### Findings - [dimension] — ### Pre-existing issues (outside locked diff) - ### Coverage gaps - Verdict: COMPLETE-PASS | PARTIAL-PASS | BLOCK ``` Verdict mapping: `COMPLETE-PASS` — every dimension is `swept`, `n/a`, or skipped for requester exclusion, and Coverage gaps is `None`. `PARTIAL-PASS` — coverage gaps exist, or a dimension is skipped for missing expertise/context (any skip without requester agreement); name what a follow-up pass must cover. `BLOCK` — insufficient input. Emit exactly one value for each enum field; do not copy enum lists or angle-bracket placeholders into the report. No-findings path: full coverage with no findings is a valid `COMPLETE-PASS`; keep the `### Findings` heading with the single line `Findings: none` under it. ## Error Handling Use this reduced template when required input is unavailable: ```markdown ## Single-Pass Review Report Verdict: BLOCK - Missing input: - Cannot evaluate: - Smallest addition to proceed: ``` ## Examples For a three-file diff, a file-by-file review may cover all applicable dimensions in one traversal. Mark a dimension `swept` only after considering all three files. If one file was missed, report that file–dimension pair under Coverage gaps and return `PARTIAL-PASS`. ## Definition of Done All eight dimensions appear in the coverage declaration, every finding carries a dimension tag, coverage gaps are explicit, and the verdict follows the mapping.