diff --git a/twisted/cred/test/test_cred.py b/twisted/cred/test/test_cred.py index e639d0d..110911d 100644 --- a/twisted/cred/test/test_cred.py +++ b/twisted/cred/test/test_cred.py @@ -16,6 +16,7 @@ from twisted.python.compat import nativeString, networkString from twisted.python import components from twisted.internet import defer from twisted.cred import checkers, credentials, portal, error +from twisted.test.proto_helpers import LogCapture try: from crypt import crypt @@ -213,7 +214,10 @@ class OnDiskDatabaseTests(unittest.TestCase): """ self.db = checkers.FilePasswordDB('test_thisbetternoteverexist.db') - self.failUnlessRaises(error.UnauthorizedLogin, self.db.getUser, 'user') + with LogCapture() as lc: + self.failUnlessRaises(error.UnauthorizedLogin, self.db.getUser, '') + self.assertIn('Unable to load credentials db: IOError', lc.asText) + def testUserLookup(self): diff --git a/twisted/internet/test/test_protocol.py b/twisted/internet/test/test_protocol.py index 1a4c5a7..c488e41 100644 --- a/twisted/internet/test/test_protocol.py +++ b/twisted/internet/test/test_protocol.py @@ -18,8 +18,9 @@ from twisted.internet.protocol import ( Protocol, ClientCreator, Factory, ProtocolToConsumerAdapter, ConsumerToProtocolAdapter) from twisted.trial.unittest import TestCase -from twisted.test.proto_helpers import MemoryReactorClock, StringTransport -from twisted.logger import LogLevel, globalLogPublisher +from twisted.test.proto_helpers import ( + MemoryReactorClock, StringTransport, LogCapture) +from twisted.logger import LogLevel @@ -399,18 +400,14 @@ class FactoryTests(TestCase): L{Factory.doStart} logs that it is starting a factory, followed by the L{repr} of the L{Factory} instance that is being started. """ - events = [] - globalLogPublisher.addObserver(events.append) - self.addCleanup( - lambda: globalLogPublisher.removeObserver(events.append)) - f = Factory() - f.doStart() - - self.assertIs(events[0]['factory'], f) - self.assertEqual(events[0]['log_level'], LogLevel.info) - self.assertEqual(events[0]['log_format'], - 'Starting factory {factory!r}') + with LogCapture() as lc: + f.doStart() + self.assertIs(lc.asEvents[0]['factory'], f) + self.assertEqual(lc.asEvents[0]['log_level'], LogLevel.info) + self.assertIn( + 'Starting factory