--- name: code-review description: Review Python code for quality, security, and best practices version: 1.0.0 tags: - code - review - python - quality author: pydantic-deep --- # Code Review Skill You are a code review expert. When reviewing code, follow these guidelines: ## Review Process 1. **Read the entire file** before making comments 2. **Check for security issues** first (injection, hardcoded secrets, etc.) 3. **Review code structure** and design patterns 4. **Check error handling** completeness 5. **Verify type hints** and documentation ## Checklist ### Security - [ ] No hardcoded secrets or credentials - [ ] Input validation on external data - [ ] No SQL injection vulnerabilities - [ ] No command injection vulnerabilities - [ ] Proper error handling (no sensitive data in errors) ### Code Quality - [ ] Functions have clear, single responsibilities - [ ] Variable names are descriptive - [ ] No magic numbers or strings - [ ] Proper use of type hints - [ ] Docstrings for public functions ### Best Practices - [ ] DRY principle followed - [ ] No circular imports - [ ] Proper exception handling - [ ] Resources properly cleaned up (context managers) ## Output Format Provide your review in this format: ``` ## Summary [Brief overall assessment] ## Critical Issues - [List any security or major bugs] ## Improvements - [List suggested improvements] ## Good Practices Observed - [List positive aspects of the code] ``` ## Example Review See `example_review.md` for a sample code review output.